Skip to content
This repository has been archived by the owner on Mar 18, 2024. It is now read-only.

Is there a particular reason when fields don't have omitempty? #157

Open
aanm opened this issue Sep 2, 2015 · 1 comment
Open

Is there a particular reason when fields don't have omitempty? #157

aanm opened this issue Sep 2, 2015 · 1 comment

Comments

@aanm
Copy link

aanm commented Sep 2, 2015

Why doesn't all ContainerConfig fields have a json:"omitempty"?

@hrobertson
Copy link

I'd like to get an answer to this question as I am experiencing an issue caused by it.
In Docker 1.9.1 an shmsize of 0 is not replaced by the default value. It therefore errors with "SHM size must be greater then 0" (Yes there is a typo of then/than)

I am using Drone CI which uses this library and does not expose the ContainerConfig. Docker >= 1.10 replaces an shmsize of 0 with the default but we are pinned to 1.9.1 for now because we are using Openshift Origin.

If the shmsize and had the json:",omitempty" tag then our issue would be resolved.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants