From e2b7b6c8e57a3f5ffec6a6b160fc0f87e35c5c9c Mon Sep 17 00:00:00 2001 From: Sambhav Jain Date: Wed, 21 Aug 2024 12:05:47 +0530 Subject: [PATCH] workflows: disable cockroach-microbench-ci step for pull requests This change disbales the CI step for pull requests but this still runs for push step into the target branch. Also the count of the microbenchmarks are increased to get more robust results. Epic: none Release note: None --- .github/workflows/github-actions-essential-ci.yml | 2 ++ build/github/cockroach-microbench-ci.sh | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/.github/workflows/github-actions-essential-ci.yml b/.github/workflows/github-actions-essential-ci.yml index 5016264f3d61..0f61bca0bceb 100644 --- a/.github/workflows/github-actions-essential-ci.yml +++ b/.github/workflows/github-actions-essential-ci.yml @@ -347,6 +347,8 @@ jobs: if: always() cockroach-microbench-ci: runs-on: [ self-hosted, basic_runner_group ] + # TODO(sambhav-jain-16): enable this for pull requests also + if: ${{ github.event_name == 'push' }} timeout-minutes: 60 steps: - uses: actions/checkout@v4 diff --git a/build/github/cockroach-microbench-ci.sh b/build/github/cockroach-microbench-ci.sh index 477e62071bcd..2f6d9cbbaea9 100755 --- a/build/github/cockroach-microbench-ci.sh +++ b/build/github/cockroach-microbench-ci.sh @@ -44,7 +44,7 @@ bazel test //pkg/sql/tests:tests_test \ --test_sharding_strategy=disabled \ --test_arg=-test.cpu --test_arg=1 \ --test_arg=-test.v \ - --test_arg=-test.count=4 \ + --test_arg=-test.count=10 \ --test_arg=-test.benchmem \ --crdb_test_off \ --test_output=all > "$log_output_file_path"