Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

organize js for easier expansion #18

Open
sambrenner opened this issue Jul 18, 2015 · 2 comments
Open

organize js for easier expansion #18

sambrenner opened this issue Jul 18, 2015 · 2 comments

Comments

@sambrenner
Copy link
Owner

i was going to work on #14 but thought it might make sense to start breaking out some of the JS so we don't end up with one massive file full of anonymous functions.

@milovanderlinden do you want to merge some of your JS changes into master so i don't end up breaking your work?

@milovanderlinden
Copy link
Contributor

I do, thank you! I isolated my development into https://github.com/dogodigi/soundboard/tree/2.0 maybe it would be good if you would test the 2.0 branch once to see what is there and what needs to be added?

@milovanderlinden
Copy link
Contributor

I am going to slow merge. I will first update soundboard.js and the routes/index.js to use data- elements instead of rely on the name of the sound file. This is needed to make way for track-lenght and nicer titles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants