Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Youtube tag enhancements #585

Closed
wants to merge 12 commits into from
Closed

Youtube tag enhancements #585

wants to merge 12 commits into from

Conversation

abetis
Copy link
Contributor

@abetis abetis commented Nov 25, 2017

The PR includes:

  • Change in APIs to allow bbcode formatter access the global options and templates
  • youtubeParameters option added to allow people use different video sizes and other formatting options in the generated HTML code
  • The formatter now uses the same youtube HTML template as the editor, and the youtubeParameters option
  • YouTube start playing time is now supported on both the editor and the formatter
  • Added processing of "time_continue" URL parameter as a start time, its added by youtube player when switching from an embedded player to youtube's page big player.
  • Unit tests updated according to the API changes
  • Added unit tests to check YouTube start time

The API change now allows storing all the HTML used in the parser in the templates, that could be a good idea to have everything in central place since there are some duplicates in the editor and the parser...

ie [size=150] means 150% of the current font size
it creates a non needed element with the space after the marker is
removed, and that cause the following text to remove the trailing spaces,
while those should be there since the marker space is not shown
Will allow access to youtube video parameters
Youtube command now uses the template and options.
@abetis
Copy link
Contributor Author

abetis commented Apr 11, 2018

Replaced by #687

@abetis abetis closed this Apr 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant