Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot save collection after adding to sharing #2873

Closed
jgondron opened this issue Mar 29, 2018 · 1 comment
Closed

Cannot save collection after adding to sharing #2873

jgondron opened this issue Mar 29, 2018 · 1 comment
Assignees
@jgondron
Labels
bug

Comments

@jgondron
Copy link
Contributor

Descriptive summary

After adding to sharing on a collection, clicking "Save Changes" throws a "ActionController::InvalidAuthenticityToken" exception

Steps to reproduce the behavior

  1. Go to dashboard/collections
  2. Go to Sharing
  3. Add a user to sharing
  4. After the user finishes adding, click Save changes
jgondron added a commit that referenced this issue Mar 29, 2018
@jgondron
Fix for #2873 - CSRF Exception after adding to Collections/Sharing
4ed084e 
- Found the root issue is related to turbolinks + jquery-ujs + a button that uses ajax to post. This may also fix #1191. Adding a call to refresh the CSRF tokens in the rendered DOM after turbolinks loads fixes it.
@jgondron jgondron self-assigned this Mar 29, 2018
@no-reply no-reply added the bug label Mar 30, 2018
@elrayle elrayle mentioned this issue Mar 31, 2018
Merged
elrayle added a commit that referenced this issue Mar 31, 2018
@elrayle
test for invalid tokens error
2165a87 
This test follows the steps to reproduce the error in issue #2873.  But I can’t reproduce the error when I remove the original PR fix that adds turbolinks_events.js.  So I cannot confirm that this test can serve as a regression test.
elrayle added a commit that referenced this issue Mar 31, 2018
@elrayle
test for invalid tokens error
232057f 
This test follows the steps to reproduce the error in issue #2873.  But I can’t reproduce the error when I remove the original PR fix that adds turbolinks_events.js.  So I cannot confirm that this test can serve as a regression test.
no-reply pushed a commit that referenced this issue Apr 2, 2018
Merge pull request #2875 from samvera/2873-csrf-exception
e37466a 
Fix for #2873 - CSRF Exception after adding to Collections/Sharing
@jgondron
Copy link
Contributor Author

jgondron commented Apr 3, 2018

Fixed by #2875

@jgondron jgondron closed this as completed Apr 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jgondron jgondron

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@no-reply @jgondron