Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test and remove all instances of data: { turbolinks: false } if no longer needed #2881

Closed
elrayle opened this issue Mar 31, 2018 · 0 comments
Assignees
Milestone

Comments

@elrayle
Copy link
Contributor

elrayle commented Mar 31, 2018

Descriptive summary

Need to systematically remove and test that data: { turbolinks: false } (and other variants of turning off turbolinks) are not needed. There is a general fix for invalid tokens failure associated with turbolinks (#1191) in PR #2875.

Rationale

Remove technical debt of code to turn off turbolinks since it is no longer needed.

Expected behavior

Removal of turbolinks: false on links and buttons should not throw invalid authenticity tokens and should perform the action specified by the link/button.

Actual behavior

Removal of turbolinks: false on links and buttons throws invalid authenticity tokens exception.

Steps to reproduce the behavior

  1. Search for turbolinks in app/views
  2. Remove code that turns turbolinks off for a button/link
  3. Test the behavior of the button/link and confirm the invalid authenticity token exception is not thrown

Related work

PR #2875 CSRF Exception after adding to Collections/Sharing
Link to related tickets or prior related work here.

@no-reply no-reply added this to the 2.x series milestone Apr 13, 2018
@kdid kdid self-assigned this Jul 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants