Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links on New User Collection page to not meet WCAG AA minimum color contrast requirements #6796

Closed
rjkati opened this issue May 16, 2024 · 6 comments · May be fixed by #6984
Closed

Links on New User Collection page to not meet WCAG AA minimum color contrast requirements #6796

rjkati opened this issue May 16, 2024 · 6 comments · May be fixed by #6984

Comments

@rjkati
Copy link

rjkati commented May 16, 2024

Descriptive summary

On dev.nurax.samvera.org (Hyrax 5.0.1), the Add another Title and Cancel links do not meet WCAG AA minimum color contrast requirements

Steps to reproduce the behavior in User Interface (UI)

  1. In Chrome, download the Site Improve browser extension
  2. Go to https://dev.nurax.samvera.org/dashboard/collections/new?locale=en&collection_type_id=3 and run the Site Improve browser extension

color_contrast_links

@rjkati
Copy link
Author

rjkati commented May 17, 2024

This issue also occurs on the following pages:

Hopefully, a CSS tweak can fix all of these, but please comment here if it is preferable to create tickets for each occurrence and I'll do that.

@eporter23
Copy link
Contributor

Similar alerts are noted for Create New Work (single work) for the "Add Another..."/"Remove" links when a multi-valued field option is presented.

@aahurford
Copy link

On nurax-pg, this shows as a AAA issue

rodyoukai added a commit to rodyoukai/hyrax that referenced this issue Dec 11, 2024
@jlhardes
Copy link
Contributor

I am no longer seeing any SiteImprove issues on the Add New Collection edit form on dev.nurax or pg.nurax. I am also not seeing any SiteImprove issues on the Edit Work page, Add new work by batch, Edit File (at least not the color contrast for the Cancel link), Edit Collection, or Collection Admin page (at least not the color contrast for those links). Some other PR must have also addressed these link color contrast issues? I'm not sure which one but there is a bootstrap override in place to set $blue: #0056B3 and that seems to be the color that is applied now on all of these links and is passing WCAG AA.

@christhepianist
Copy link

Confirmed that this is no longer an issue on the Add New Collection, Edit Work, Add New Works by Batch, Edit File, Edit Collection or Collections (I think this is the Collection Admin page) pages.

@jlhardes
Copy link
Contributor

Took me a minute to find the PR but here it is: #6896 That was for #6755 Closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready for Dev/Doc (priority ordered)
Development

Successfully merging a pull request may close this issue.

5 participants