-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LOC bug when using "--" #61
Comments
Related unit test that doesn't work:
|
The problem seems to lie with LOC itself. This returns the same result http://id.loc.gov/search/?q=History--&q= |
We automatically appended the wildcard in the past but that seemed to cause other issues. See the discussion over the removal of the wildcard in pull request #49 . Possibly need some logic to only append it in certain cases? Or make it a setting of some sort? |
Ah, thanks for pointing that out... completely forgot about it. I guess I'd lean towards an option to pass via the url or something, as it will vary per authority. |
Hi, |
Setup / Expected
The documentation gives the following example:
QA then presents this data to you in JSON format:
Actual
The data actually returned is more like the following
The Issue
A "--" does not seem to be processed correctly. For example, searching for "History Philosophy" will return results more like the first example. As is, about half of the results currently do not contain the word "history" nor any "--". I have no yet done appropriate research into details of this behavior besides noticing it during recent testing.
The text was updated successfully, but these errors were encountered: