Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make some optional fields positional if possible #27

Open
samvv opened this issue Nov 11, 2024 · 0 comments
Open

Make some optional fields positional if possible #27

samvv opened this issue Nov 11, 2024 · 0 comments
Assignees
@samvv
Labels
component:ast/cst Anything related to representing grammars as AST/CST nodes 💎 enhancement New feature or request

Comments

@samvv
Copy link
Owner

samvv commented Nov 11, 2024

For example, we have for PyRetStmt:

def __init__(self, *, value: Expr | None = None): ...

We would like to generate:

def __init__(self, *, value: Expr | None = None): ...

Might a rule of thumb be that if the field is optional irrespective of which coercions were applied that it is positional?
@samvv samvv added 💎 enhancement New feature or request component:ast/cst Anything related to representing grammars as AST/CST nodes labels Nov 11, 2024
@samvv samvv self-assigned this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samvv samvv

Labels
component:ast/cst Anything related to representing grammars as AST/CST nodes 💎 enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samvv