Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Punctuated type is not correctly visited #31

Open
samvv opened this issue Nov 13, 2024 · 2 comments
Open

Punctuated type is not correctly visited #31

samvv opened this issue Nov 13, 2024 · 2 comments
Assignees
@samvv
Labels
🐛 bug Something isn't working component:ast/cst Anything related to representing grammars as AST/CST nodes
Milestone
1.0.0

Comments

@samvv
Copy link
Owner

samvv commented Nov 13, 2024

Checks might be missing for None in the Python AST/CST generator.
@samvv samvv added 🐛 bug Something isn't working component:ast/cst Anything related to representing grammars as AST/CST nodes labels Nov 13, 2024
@samvv samvv self-assigned this Nov 13, 2024
@samvv
Copy link
Owner Author

samvv commented Nov 14, 2024

Issue was in the rewriter.

samvv added a commit that referenced this issue Nov 14, 2024
@samvv
Update Punctuated API and fix issue #31
326ddbd
@samvv
Copy link
Owner Author

samvv commented Nov 14, 2024

Issue persists but now because last is accessed before it is known if there are any elements at all in the Punctuated type.

@samvv samvv added this to the 1.0.0 milestone Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samvv samvv

Labels
🐛 bug Something isn't working component:ast/cst Anything related to representing grammars as AST/CST nodes
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
1 participant
@samvv