From 61c1e65ac4a42cf7b5c3b3c181cb1e0d610b362f Mon Sep 17 00:00:00 2001 From: ananyaspatil Date: Tue, 19 Nov 2024 13:04:35 -0500 Subject: [PATCH 1/5] Edit Modal Message, add fix to CourseCheckBox --- .../NewSubscriptionsLimitModal.tsx | 6 +-- components/panels/CourseCheckBox.tsx | 40 ++++++++++++++----- 2 files changed, 32 insertions(+), 14 deletions(-) diff --git a/components/notifications/NewSubscriptionsLimitModal.tsx b/components/notifications/NewSubscriptionsLimitModal.tsx index 1bc6575d..d37e9f8b 100644 --- a/components/notifications/NewSubscriptionsLimitModal.tsx +++ b/components/notifications/NewSubscriptionsLimitModal.tsx @@ -25,11 +25,11 @@ export default function NewSubscriptionsLimitModal({ - Notifications are up! + Unable to turn on notifs? - We{`'`}re limiting users to 12 subscriptions at a time to keep - SearchNEU running for our growing NEU community. + Users are limited to 12 notifications at a time. Please unsubscribe + from a class to turn on other notifications. diff --git a/components/panels/CourseCheckBox.tsx b/components/panels/CourseCheckBox.tsx index 4a6e7227..4b9dcbe4 100644 --- a/components/panels/CourseCheckBox.tsx +++ b/components/panels/CourseCheckBox.tsx @@ -85,7 +85,8 @@ export default function CourseCheckBox({
- + {checked || + (!notificationsLimitReached() && ( + + ))} + {!checked && notificationsLimitReached() && ( + + )}
Date: Tue, 19 Nov 2024 18:09:42 -0500 Subject: [PATCH 2/5] changed modal message --- .../notifications/NewSubscriptionsLimitModal.tsx | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/components/notifications/NewSubscriptionsLimitModal.tsx b/components/notifications/NewSubscriptionsLimitModal.tsx index d37e9f8b..b34363e1 100644 --- a/components/notifications/NewSubscriptionsLimitModal.tsx +++ b/components/notifications/NewSubscriptionsLimitModal.tsx @@ -2,6 +2,7 @@ import React, { ReactElement } from 'react'; import Modal from '../Modal'; import X from '../icons/X.svg'; import Boston from '../icons/boston.svg'; +import CryingHusky3 from '../icons/crying-husky-3.svg'; interface NewSubscriptionsLimitModalProps { visible: boolean; @@ -24,12 +25,15 @@ export default function NewSubscriptionsLimitModal({ - - Unable to turn on notifs? + + Notifications Issues - Users are limited to 12 notifications at a time. Please unsubscribe - from a class to turn on other notifications. + We've found issues with unsubscribing from notifications. + + + We're very sorry about the inconvenience this causes, and are + working to deploy fixes ASAP. Thank you! From a6ec451696ecb97e3ca015ad78d4696a6f3233c8 Mon Sep 17 00:00:00 2001 From: ananyaspatil Date: Tue, 19 Nov 2024 18:14:32 -0500 Subject: [PATCH 3/5] resolve lint error --- components/notifications/NewSubscriptionsLimitModal.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/components/notifications/NewSubscriptionsLimitModal.tsx b/components/notifications/NewSubscriptionsLimitModal.tsx index b34363e1..8d135616 100644 --- a/components/notifications/NewSubscriptionsLimitModal.tsx +++ b/components/notifications/NewSubscriptionsLimitModal.tsx @@ -29,10 +29,10 @@ export default function NewSubscriptionsLimitModal({ Notifications Issues - We've found issues with unsubscribing from notifications. + We found issues with unsubscribing from notifications. - We're very sorry about the inconvenience this causes, and are + We are very sorry about the inconvenience this causes, and are working to deploy fixes ASAP. Thank you! From 2d504301cdb4fa6414cb87ad63890e0ae5676df7 Mon Sep 17 00:00:00 2001 From: ananyaspatil Date: Tue, 19 Nov 2024 22:55:06 -0500 Subject: [PATCH 4/5] changed modal text --- .../notifications/NewSubscriptionsLimitModal.tsx | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/components/notifications/NewSubscriptionsLimitModal.tsx b/components/notifications/NewSubscriptionsLimitModal.tsx index 8d135616..a26a24a5 100644 --- a/components/notifications/NewSubscriptionsLimitModal.tsx +++ b/components/notifications/NewSubscriptionsLimitModal.tsx @@ -26,15 +26,21 @@ export default function NewSubscriptionsLimitModal({ - Notifications Issues + Recent Issues - We found issues with unsubscribing from notifications. + We have identified issues with unsubscribing from notifications. - We are very sorry about the inconvenience this causes, and are - working to deploy fixes ASAP. Thank you! + Additionally, we have not been been displaying professor names as + Banner recently changed how it shows professor data. +
+ + We are very sorry about the inconvenience these issues cause, and + are working to deploy fixes ASAP. Thank you! + +
From 2729b336e265791eae9d9f644f758b45981b918e Mon Sep 17 00:00:00 2001 From: ananyaspatil Date: Tue, 19 Nov 2024 22:58:35 -0500 Subject: [PATCH 5/5] changed back modal header text --- components/notifications/NewSubscriptionsLimitModal.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/notifications/NewSubscriptionsLimitModal.tsx b/components/notifications/NewSubscriptionsLimitModal.tsx index a26a24a5..a0f39f05 100644 --- a/components/notifications/NewSubscriptionsLimitModal.tsx +++ b/components/notifications/NewSubscriptionsLimitModal.tsx @@ -26,7 +26,7 @@ export default function NewSubscriptionsLimitModal({ - Recent Issues + Notification Issues We have identified issues with unsubscribing from notifications.