Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn back on notebook tests #531

Open
sserita opened this issue Jan 21, 2025 · 1 comment
Open

Turn back on notebook tests #531

sserita opened this issue Jan 21, 2025 · 1 comment

Comments

@sserita
Copy link
Contributor

sserita commented Jan 21, 2025

Currently, the notebook tests are off on beta and master with a comment that they started failing in May 2024. We should re-evaluate those failures and turn these tests back on.

@coreyostrove
Copy link
Contributor

Additional context (clawed deep from memory): IIRC these didn't start failing because of any code changes we made directly, but rather because for whatever reason some cells started randomly taking forever to run, eventually timing out. We concluded that the most likely explanation (since none of the devs at the time could reproduce the behavior locally) was that some combination of package versions being installed on the runners was colliding in a manner that behaved badly. We spent a while comparing pip installation logs from before and after this issue started and didn't make any headway at that time. If our hypothesis was correct then this is a prime candidate for an issue that would have magically fixed itself given enough time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants