From 6b116105cf96d51e1e05807827c53bc6ebcd4fbf Mon Sep 17 00:00:00 2001
From: Greg Sjaardema <gsjaardema@gmail.com>
Date: Wed, 29 Nov 2023 13:32:51 -0700
Subject: [PATCH] Address global variables should be const

---
 packages/seacas/applications/conjoin/CJ_Version.h  | 2 +-
 packages/seacas/applications/cpup/CP_Version.h     | 2 +-
 packages/seacas/applications/ejoin/EJ_Version.h    | 2 +-
 packages/seacas/applications/epu/EP_Version.h      | 2 +-
 packages/seacas/applications/exo2mat/exo2mat.C     | 2 +-
 packages/seacas/applications/exodiff/ED_Version.h  | 4 ++--
 packages/seacas/applications/exomatlab/exomatlab.C | 4 ++--
 packages/seacas/applications/mat2exo/mat2exo.C     | 2 +-
 packages/seacas/applications/slice/SL_Version.h    | 2 +-
 packages/seacas/applications/zellij/ZE_Version.h   | 2 +-
 10 files changed, 12 insertions(+), 12 deletions(-)

diff --git a/packages/seacas/applications/conjoin/CJ_Version.h b/packages/seacas/applications/conjoin/CJ_Version.h
index 60bea34e5d..d66cfd712c 100644
--- a/packages/seacas/applications/conjoin/CJ_Version.h
+++ b/packages/seacas/applications/conjoin/CJ_Version.h
@@ -7,7 +7,7 @@
 #include <array>
 #include <string>
 
-static std::array<std::string, 3> qainfo{
+static const std::array<std::string, 3> qainfo{
     "conjoin",
     "1.4.10",
     "2023/08/18",
diff --git a/packages/seacas/applications/cpup/CP_Version.h b/packages/seacas/applications/cpup/CP_Version.h
index a4ad07f722..8ba908eaf3 100644
--- a/packages/seacas/applications/cpup/CP_Version.h
+++ b/packages/seacas/applications/cpup/CP_Version.h
@@ -8,4 +8,4 @@
 #pragma once
 #include <array>
 #include <string>
-static std::array<std::string, 3> qainfo{"cpup", "0.95 beta", "2023/04/25"};
+static const std::array<std::string, 3> qainfo{"cpup", "0.95 beta", "2023/04/25"};
diff --git a/packages/seacas/applications/ejoin/EJ_Version.h b/packages/seacas/applications/ejoin/EJ_Version.h
index 44eb43fd01..a0bb72b7c5 100644
--- a/packages/seacas/applications/ejoin/EJ_Version.h
+++ b/packages/seacas/applications/ejoin/EJ_Version.h
@@ -7,7 +7,7 @@
 #include <array>
 #include <string>
 
-static std::array<std::string, 3> qainfo{
+static const std::array<std::string, 3> qainfo{
     "ejoin",
     "2023/06/16",
     "1.6.1",
diff --git a/packages/seacas/applications/epu/EP_Version.h b/packages/seacas/applications/epu/EP_Version.h
index ed98a44852..a5ebd49927 100644
--- a/packages/seacas/applications/epu/EP_Version.h
+++ b/packages/seacas/applications/epu/EP_Version.h
@@ -9,7 +9,7 @@
 #include <array>
 #include <string>
 
-static std::array<std::string, 3> qainfo{
+static const std::array<std::string, 3> qainfo{
     "epu --  E Pluribus Unum",
     "6.07",
     "2023/05/17",
diff --git a/packages/seacas/applications/exo2mat/exo2mat.C b/packages/seacas/applications/exo2mat/exo2mat.C
index 91b72d25f8..19ed70dac5 100644
--- a/packages/seacas/applications/exo2mat/exo2mat.C
+++ b/packages/seacas/applications/exo2mat/exo2mat.C
@@ -58,7 +58,7 @@ namespace {
   mat_t *mat_file = nullptr; /* file for binary .mat output */
   bool   debug    = false;
 
-  std::array<std::string, 3> qainfo{"exo2mat", "2021/09/27", "4.08"};
+  const std::array<std::string, 3> qainfo{"exo2mat", "2021/09/27", "4.08"};
 
   void logger(const char *message)
   {
diff --git a/packages/seacas/applications/exodiff/ED_Version.h b/packages/seacas/applications/exodiff/ED_Version.h
index 4efbd0b7b7..5cc927bbd0 100644
--- a/packages/seacas/applications/exodiff/ED_Version.h
+++ b/packages/seacas/applications/exodiff/ED_Version.h
@@ -5,5 +5,5 @@
 // See packages/seacas/LICENSE for details
 #pragma once
 
-static std::string version("3.28");
-static std::string verdate("2023-11-14");
+static const std::string version("3.28");
+static const std::string verdate("2023-11-14");
diff --git a/packages/seacas/applications/exomatlab/exomatlab.C b/packages/seacas/applications/exomatlab/exomatlab.C
index 2c27a3bf33..f162725655 100644
--- a/packages/seacas/applications/exomatlab/exomatlab.C
+++ b/packages/seacas/applications/exomatlab/exomatlab.C
@@ -51,8 +51,8 @@ namespace {
 // ========================================================================
 
 namespace {
-  std::string codename;
-  std::string version = "1.2";
+  std::string       codename;
+  const std::string version = "1.2";
 } // namespace
 
 int main(int argc, char *argv[])
diff --git a/packages/seacas/applications/mat2exo/mat2exo.C b/packages/seacas/applications/mat2exo/mat2exo.C
index 399cc92c97..68d94c2f80 100644
--- a/packages/seacas/applications/mat2exo/mat2exo.C
+++ b/packages/seacas/applications/mat2exo/mat2exo.C
@@ -53,7 +53,7 @@ mat_t *mat_file = nullptr; /* file for binary .mat input */
 
 /**********************************************************************/
 namespace {
-  std::array<std::string, 3> qainfo{"mat2exo", "2021/09/27", "4.06"};
+  const std::array<std::string, 3> qainfo{"mat2exo", "2021/09/27", "4.06"};
 }
 
 /**********************************************************************/
diff --git a/packages/seacas/applications/slice/SL_Version.h b/packages/seacas/applications/slice/SL_Version.h
index 93e1aebcc1..cb5e6cb057 100644
--- a/packages/seacas/applications/slice/SL_Version.h
+++ b/packages/seacas/applications/slice/SL_Version.h
@@ -7,7 +7,7 @@
 #include <array>
 #include <string>
 
-static std::array<std::string, 3> qainfo{
+static const std::array<std::string, 3> qainfo{
     "slice",
     "2023/09/14",
     "2.1.05",
diff --git a/packages/seacas/applications/zellij/ZE_Version.h b/packages/seacas/applications/zellij/ZE_Version.h
index f98047543f..ba32353dbf 100644
--- a/packages/seacas/applications/zellij/ZE_Version.h
+++ b/packages/seacas/applications/zellij/ZE_Version.h
@@ -7,7 +7,7 @@
 #include <array>
 #include <string>
 
-static std::array<std::string, 3> qainfo{
+static const std::array<std::string, 3> qainfo{
     "zellij",
     "2023/01/11",
     "1.5.4",