Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sap_vm_provision: Add support for AWS EC2 Spot Instances #9

Open
marcelmamula opened this issue Apr 12, 2024 · 1 comment
Open

sap_vm_provision: Add support for AWS EC2 Spot Instances #9

marcelmamula opened this issue Apr 12, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@marcelmamula
Copy link
Contributor

amazon.aws.ec2_instance module does not support creation of Spot instances

https://docs.ansible.com/ansible/latest/collections/amazon/aws/ec2_instance_module.html
This module does not support creating EC2 Spot instances.

It would be good to add support for Spot instances by using module amazon.aws.ec2_spot_instance based on user specified variable with extra inputs for Spot specific inputs like Launch Group. https://docs.ansible.com/ansible/latest/collections/amazon/aws/ec2_spot_instance_module.html

@marcelmamula marcelmamula added the enhancement New feature or request label Apr 12, 2024
@sean-freeman
Copy link
Member

sean-freeman commented Apr 13, 2024

@marcelmamula I don't think this is a good idea, for a handful of reasons:

  1. Homogeneity objective, means appending code for Spot across all Cloud Service Providers. That's a lot of work, re-testing, further bloats the input vars, and would need to be factored into long-term validation testing upon each new release.
  2. Spot are not SAP Certified, so we're adding code that will only ever be applicable to temporary sandboxes (not that I disagree with that for cost-saving). If I recall, AWS AMI are relatively flexible and can be applied to any AWS EC2 VS Instance Type (Profile) - but the other CSPs (if I recall correctly) all place a restriction on x OS Image applied to y Profile, therefore I doubt SLES4SAP / RHEL4SAP OS Images will work with other Spot compute.
  3. Spot may not be fully comprehended by end-users, they may use it by accident or misunderstand - then lose their work.

Primarily No.1 is my reason for this apprehension. I don't have personal time available to code for each platform and re-test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants