From 6ffb4dd1eef53bc4465ada758b0bdba4fd1baf63 Mon Sep 17 00:00:00 2001 From: Irina Gulina Date: Wed, 3 Jan 2024 11:57:02 +0100 Subject: [PATCH] fix typos to make codespell happy --- README.md | 2 +- docs/developer_notes/sap_swmp_dev.md | 2 +- ...e-sap-swpm-inifile-reuse-mode-sample.inifile.params | 2 +- .../tasks/oracledb_installer_minimal.yml | 2 +- .../templates/oracledb_rsp_assistants_dbca.j2 | 2 +- .../oracledb_rsp_inventory_oracleserver_ee.j2 | 2 +- roles/sap_general_preconfigure/README.md | 2 +- roles/sap_general_preconfigure/defaults/main.yml | 2 +- roles/sap_general_preconfigure/meta/argument_specs.yml | 2 +- .../tasks/RedHat/generic/increase-nofile-limits.yml | 4 ++-- .../tasks/RedHat/generic/increase-nproc-limits.yml | 4 ++-- .../sap_general_preconfigure/tasks/sapnote/1771258.yml | 2 +- .../tasks/sapnote/assert-1771258.yml | 2 +- roles/sap_ha_install_hana_hsr/tasks/main.yml | 4 ++-- roles/sap_ha_pacemaker_cluster/README.md | 4 ++-- roles/sap_ha_pacemaker_cluster/defaults/main.yml | 2 +- roles/sap_ha_pacemaker_cluster/tasks/main.yml | 4 ++-- roles/sap_hana_install/README.md | 2 +- roles/sap_hana_install/defaults/main.yml | 4 ++-- .../tasks/assert-addhosts-loop-block.yml | 4 ++-- .../tasks/RedHat/generic/disable-coredumps.yml | 2 +- roles/sap_hana_preconfigure/tasks/sapnote/2009879.yml | 5 ++--- roles/sap_hana_preconfigure/vars/RedHat_8.yml | 4 ++-- roles/sap_hana_preconfigure/vars/RedHat_9.yml | 4 ++-- roles/sap_hostagent/CONTRIBUTING.md | 4 ++-- roles/sap_hostagent/README.md | 10 +++++----- roles/sap_hostagent/tasks/config_ssl.yml | 2 +- roles/sap_hypervisor_node_preconfigure/README.md | 2 +- roles/sap_install_media_detect/README.md | 2 +- .../tasks/prepare/enable_rar_handling.yml | 2 +- .../tasks/prepare/move_files_to_main_directory.yml | 2 +- roles/sap_maintain_etc_hosts/README.md | 2 +- roles/sap_maintain_etc_hosts/meta/argument_specs.yml | 2 +- roles/sap_maintain_etc_hosts/tasks/main.yml | 2 +- .../tasks/update_host_absent.yml | 4 ++-- .../tasks/update_host_present.yml | 2 +- roles/sap_maintain_etc_hosts/tests/README.md | 2 +- roles/sap_netweaver_preconfigure/defaults/main.yml | 2 +- roles/sap_storage_setup/README.md | 2 +- roles/sap_storage_setup/meta/argument_specs.yml | 2 +- roles/sap_swpm/README.md | 2 +- roles/sap_swpm/tasks/pre_install/create_os_user.yml | 2 +- roles/sap_vm_preconfigure/defaults/main.yml | 4 ++-- tools/swpm2_parameters_inifile_generate.py | 4 ++-- 44 files changed, 62 insertions(+), 63 deletions(-) diff --git a/README.md b/README.md index d714954d4..fe8f88cb3 100644 --- a/README.md +++ b/README.md @@ -110,7 +110,7 @@ The logic has been separated to support a flexible execution of the different st ## Execution examples -There are various methods to execute the Ansible Collection, dependant on the use case. For more information, see [Execution examples with code samples](./docs/getting_started) and the summary below: +There are various methods to execute the Ansible Collection, dependent on the use case. For more information, see [Execution examples with code samples](./docs/getting_started) and the summary below: | Execution Scenario | Use Case | Target | | ---- | ---- | ---- | diff --git a/docs/developer_notes/sap_swmp_dev.md b/docs/developer_notes/sap_swmp_dev.md index 3386af300..8e562eb29 100644 --- a/docs/developer_notes/sap_swmp_dev.md +++ b/docs/developer_notes/sap_swmp_dev.md @@ -2,7 +2,7 @@ ## Errors with missing signature files for installation media -After SWPM 1.0 SP22 and SAP SWPM 2.0 SP00, all SAP Software installation media requires a seperate signature file (SIGNATURE.SMF). The signature file is missing in older installation media. +After SWPM 1.0 SP22 and SAP SWPM 2.0 SP00, all SAP Software installation media requires a separate signature file (SIGNATURE.SMF). The signature file is missing in older installation media. For example, IDES for SAP ECC 6.0 EhP8. See the following error message and SAP Note 2622019 - "EXPORT_1 is not signed" error during IDES installation. ```shell diff --git a/playbooks/vars/sample-sap-swpm-inifile-reuse-mode-sample.inifile.params b/playbooks/vars/sample-sap-swpm-inifile-reuse-mode-sample.inifile.params index 5d3466963..49ce43cba 100644 --- a/playbooks/vars/sample-sap-swpm-inifile-reuse-mode-sample.inifile.params +++ b/playbooks/vars/sample-sap-swpm-inifile-reuse-mode-sample.inifile.params @@ -123,7 +123,7 @@ NW_DDIC_Password.needDDICPasswords = false # Master password NW_GetMasterPassword.masterPwd = NewPass$321 -# Human readable form of the default login language to be preselected in SAPGUI. This Parameter is potentialy prompted in addition in the screen that also asks for the . It is only prompted in systems that have an ABAP stack. It is prompted for installation but not for system copy. It is asked in those installations, that perform the ABAP load. That could be the database load installation in case of a distributed system szenario, or in case of a standard system installation with all instances on one host. This Parameter is saved in the 'DEFAULT' profile. It is has no influence on language settings in a Java stack. Valid names are stored in a table of subcomponent 'NW_languagesInLoadChecks'. The available languages must be declaired in the 'LANGUAGES_IN_LOAD' parameter of the 'product.xml' file . In this file, the one-character representation of the languages is used. Check the same table in subcomponent 'NW_languagesInLoadChecks'. +# Human readable form of the default login language to be preselected in SAPGUI. This Parameter is potentially prompted in addition in the screen that also asks for the . It is only prompted in systems that have an ABAP stack. It is prompted for installation but not for system copy. It is asked in those installations, that perform the ABAP load. That could be the database load installation in case of a distributed system scenario, or in case of a standard system installation with all instances on one host. This Parameter is saved in the 'DEFAULT' profile. It is has no influence on language settings in a Java stack. Valid names are stored in a table of subcomponent 'NW_languagesInLoadChecks'. The available languages must be declaired in the 'LANGUAGES_IN_LOAD' parameter of the 'product.xml' file . In this file, the one-character representation of the languages is used. Check the same table in subcomponent 'NW_languagesInLoadChecks'. # NW_GetSidNoProfiles.SAP_GUI_DEFAULT_LANGUAGE = # Windows only: The drive to use diff --git a/roles/sap_anydb_install_oracle/tasks/oracledb_installer_minimal.yml b/roles/sap_anydb_install_oracle/tasks/oracledb_installer_minimal.yml index df2a59a44..2ec77bdf6 100644 --- a/roles/sap_anydb_install_oracle/tasks/oracledb_installer_minimal.yml +++ b/roles/sap_anydb_install_oracle/tasks/oracledb_installer_minimal.yml @@ -5,7 +5,7 @@ ## DISPLAY env var, not required for when Silent installation (-silent operator for RUNINSTALLER) ## DB_SID env var / -db_sid option. If unset then error "[FATAL] [INS-35072] The SID cannot be left blank." ## ORACLE_BASE env var / -oracle_base option, Oracle Base /oracle. If unset then error "[FATAL] [INS-32013] The Oracle base location is empty." If option -oracle_base unused, may cause "Using new ORACLE_BASE=/oracle/ instead of ORACLE_BASE=/oracle" which will cause directory lookup failure and error "[FATAL] [INS-35072] The SID cannot be left blank." -## ORACLE_HOME env var / -install_home opiton, Oracle Home - Installation +## ORACLE_HOME env var / -install_home option, Oracle Home - Installation ## ORACLE_HOME_NAME env var / -oracle_home_name option, Oracle Home - Installation name in Oracle Inventory. Uses a naming convention - see https://docs.oracle.com/cd/E26854_01/em.121/e37799/ch2_manage_oh.htm#OUICG137 ## OHRDBMS env var / -runtime_home, Oracle Home - Runtime ## ORA_GOLD_IMAGE_FILE_L env var / -oracle_stage option, Oracle home image file path. If unset then error "(ERROR ) - Error during unzip occurred" where no file is given to extract diff --git a/roles/sap_anydb_install_oracle/templates/oracledb_rsp_assistants_dbca.j2 b/roles/sap_anydb_install_oracle/templates/oracledb_rsp_assistants_dbca.j2 index e656818e7..108b8e5ae 100644 --- a/roles/sap_anydb_install_oracle/templates/oracledb_rsp_assistants_dbca.j2 +++ b/roles/sap_anydb_install_oracle/templates/oracledb_rsp_assistants_dbca.j2 @@ -546,7 +546,7 @@ initParams= # Datatype : Boolean # Description : Specifies whether or not to add the Sample Schemas to your database # Valid values : TRUE \ FALSE -# Default value : FASLE +# Default value : FALSE # Mandatory : No #----------------------------------------------------------------------------- sampleSchema= diff --git a/roles/sap_anydb_install_oracle/templates/oracledb_rsp_inventory_oracleserver_ee.j2 b/roles/sap_anydb_install_oracle/templates/oracledb_rsp_inventory_oracleserver_ee.j2 index 504164fa0..e51f71bda 100644 --- a/roles/sap_anydb_install_oracle/templates/oracledb_rsp_inventory_oracleserver_ee.j2 +++ b/roles/sap_anydb_install_oracle/templates/oracledb_rsp_inventory_oracleserver_ee.j2 @@ -188,7 +188,7 @@ DEINSTALL_LIST={"oracle.server","19.0.0.0.0"} #------------------------------------------------------------------------------- #Name : SHOW_DEINSTALL_CONFIRMATION #Datatype : Boolean -#Description: Set to true if deinstall confimation is needed during a deinstall session. +#Description: Set to true if deinstall confirmation is needed during a deinstall session. #Example: SHOW_DEINSTALL_CONFIRMATION = true #------------------------------------------------------------------------------- SHOW_DEINSTALL_CONFIRMATION=true diff --git a/roles/sap_general_preconfigure/README.md b/roles/sap_general_preconfigure/README.md index 636ba7660..199e452fa 100644 --- a/roles/sap_general_preconfigure/README.md +++ b/roles/sap_general_preconfigure/README.md @@ -256,7 +256,7 @@ List of SAP directories to be created.
- _Type:_ `bool` - _Default:_ `true` -Set to `false` if you do not want to modify the SELinux labels for the SAP directores set
+Set to `false` if you do not want to modify the SELinux labels for the SAP directories set
in variable `sap_general_preconfigure_sap_directories`.
### sap_general_preconfigure_size_of_tmpfs_gb diff --git a/roles/sap_general_preconfigure/defaults/main.yml b/roles/sap_general_preconfigure/defaults/main.yml index 9687a15ac..74cff579c 100644 --- a/roles/sap_general_preconfigure/defaults/main.yml +++ b/roles/sap_general_preconfigure/defaults/main.yml @@ -125,7 +125,7 @@ sap_general_preconfigure_sap_directories: # List of SAP directories to be created. sap_general_preconfigure_modify_selinux_labels: true -# Set to `false` if you do not want to modify the SELinux labels for the SAP directores set +# Set to `false` if you do not want to modify the SELinux labels for the SAP directories set # in variable `sap_general_preconfigure_sap_directories`. sap_general_preconfigure_size_of_tmpfs_gb: "{{ ((0.75 * (ansible_memtotal_mb + ansible_swaptotal_mb)) / 1024) | round | int }}" diff --git a/roles/sap_general_preconfigure/meta/argument_specs.yml b/roles/sap_general_preconfigure/meta/argument_specs.yml index 2d5993d95..5621e5b28 100644 --- a/roles/sap_general_preconfigure/meta/argument_specs.yml +++ b/roles/sap_general_preconfigure/meta/argument_specs.yml @@ -261,7 +261,7 @@ argument_specs: sap_general_preconfigure_modify_selinux_labels: default: true description: - - Set to `false` if you do not want to modify the SELinux labels for the SAP directores set + - Set to `false` if you do not want to modify the SELinux labels for the SAP directories set - in variable `sap_general_preconfigure_sap_directories`. required: false type: bool diff --git a/roles/sap_general_preconfigure/tasks/RedHat/generic/increase-nofile-limits.yml b/roles/sap_general_preconfigure/tasks/RedHat/generic/increase-nofile-limits.yml index a96d6a84d..43788f3e5 100644 --- a/roles/sap_general_preconfigure/tasks/RedHat/generic/increase-nofile-limits.yml +++ b/roles/sap_general_preconfigure/tasks/RedHat/generic/increase-nofile-limits.yml @@ -2,7 +2,7 @@ # Reasons for noqa: 1. Tabs can increase readability; # 2. The example in man limits.conf is tab formatted; -# 3. It is difficult to replace tabs by spaces for entries for which their lenghts are not known +# 3. It is difficult to replace tabs by spaces for entries for which their lengths are not known - name: Set the hard and soft limit for the max number of open files per process (nofile) to 1048576 for group 'sapsys' # noqa no-tabs ansible.builtin.lineinfile: @@ -19,7 +19,7 @@ # Reasons for noqa: 1. Tabs can increase readability; # 2. The example in man limits.conf is tab formatted; -# 3. It is difficult to replace tabs by spaces for entries for which their lenghts are not known +# 3. It is difficult to replace tabs by spaces for entries for which their lengths are not known - name: Set the hard and soft limit for the max number of open files per process (nofile) to 1048576 for group '{{ sap_general_preconfigure_db_group_name }}' # noqa no-tabs ansible.builtin.lineinfile: diff --git a/roles/sap_general_preconfigure/tasks/RedHat/generic/increase-nproc-limits.yml b/roles/sap_general_preconfigure/tasks/RedHat/generic/increase-nproc-limits.yml index a9b25a495..81537d6ce 100644 --- a/roles/sap_general_preconfigure/tasks/RedHat/generic/increase-nproc-limits.yml +++ b/roles/sap_general_preconfigure/tasks/RedHat/generic/increase-nproc-limits.yml @@ -2,7 +2,7 @@ # Reasons for noqa: 1. Tabs can increase readability; # 2. The example in man limits.conf is tab formatted; -# 3. It is difficult to replace tabs by spaces for entries for which their lenghts are not known +# 3. It is difficult to replace tabs by spaces for entries for which their lengths are not known - name: Set the hard and soft limit for the max number of processes per user (nproc) to unlimited for group 'sapsys' # noqa no-tabs ansible.builtin.lineinfile: @@ -19,7 +19,7 @@ # Reasons for noqa: 1. Tabs can increase readability; # 2. The example in man limits.conf is tab formatted; -# 3. It is difficult to replace tabs by spaces for entries for which their lenghts are not known +# 3. It is difficult to replace tabs by spaces for entries for which their lengths are not known - name: Set the hard and soft limit for the max number of processes per user (nproc) to unlimited for group '{{ sap_general_preconfigure_db_group_name }}' # noqa no-tabs ansible.builtin.lineinfile: diff --git a/roles/sap_general_preconfigure/tasks/sapnote/1771258.yml b/roles/sap_general_preconfigure/tasks/sapnote/1771258.yml index 6d6a290b9..da081396e 100644 --- a/roles/sap_general_preconfigure/tasks/sapnote/1771258.yml +++ b/roles/sap_general_preconfigure/tasks/sapnote/1771258.yml @@ -4,7 +4,7 @@ - name: Configure - Display SAP note number 1771258 and its version ansible.builtin.debug: msg: "SAP note {{ (__sap_general_preconfigure_sapnotes_versions | selectattr('number', 'match', '^1771258$') | first).number }} - (version {{ (__sap_general_preconfigure_sapnotes_versions | selectattr('number', 'match', '^1771258$') | first).version }}): User and system resouce limits" + (version {{ (__sap_general_preconfigure_sapnotes_versions | selectattr('number', 'match', '^1771258$') | first).version }}): User and system resource limits" - name: Import tasks from '../RedHat/generic/increase-nofile-limits.yml' ansible.builtin.import_tasks: ../RedHat/generic/increase-nofile-limits.yml diff --git a/roles/sap_general_preconfigure/tasks/sapnote/assert-1771258.yml b/roles/sap_general_preconfigure/tasks/sapnote/assert-1771258.yml index a5b82dc82..ac06c3a6e 100644 --- a/roles/sap_general_preconfigure/tasks/sapnote/assert-1771258.yml +++ b/roles/sap_general_preconfigure/tasks/sapnote/assert-1771258.yml @@ -4,7 +4,7 @@ - name: Assert - Display SAP note number 1771258 and its version ansible.builtin.debug: msg: "SAP note {{ (__sap_general_preconfigure_sapnotes_versions | selectattr('number', 'match', '^1771258$') | first).number }} - (version {{ (__sap_general_preconfigure_sapnotes_versions | selectattr('number', 'match', '^1771258$') | first).version }}): User and system resouce limits" + (version {{ (__sap_general_preconfigure_sapnotes_versions | selectattr('number', 'match', '^1771258$') | first).version }}): User and system resource limits" - name: Import tasks from '../RedHat/generic/assert-nofile-limits.yml' ansible.builtin.import_tasks: ../RedHat/generic/assert-nofile-limits.yml diff --git a/roles/sap_ha_install_hana_hsr/tasks/main.yml b/roles/sap_ha_install_hana_hsr/tasks/main.yml index 7d33bf2bf..8af8c44ea 100644 --- a/roles/sap_ha_install_hana_hsr/tasks/main.yml +++ b/roles/sap_ha_install_hana_hsr/tasks/main.yml @@ -31,8 +31,8 @@ that: - __sap_ha_install_hana_hsr_connection.node_ip is defined - __sap_ha_install_hana_hsr_connection.node_ip != "" - fail_msg: "The IP adress configured for HSR does not exist on this host" - success_msg: "The IP adress for HSR is configured on this host" + fail_msg: "The IP address configured for HSR does not exist on this host" + success_msg: "The IP address for HSR is configured on this host" tags: always - name: "SAP HSR - Pick up primary node name from definition" diff --git a/roles/sap_ha_pacemaker_cluster/README.md b/roles/sap_ha_pacemaker_cluster/README.md index 5629e92ae..3bf383ca8 100644 --- a/roles/sap_ha_pacemaker_cluster/README.md +++ b/roles/sap_ha_pacemaker_cluster/README.md @@ -84,7 +84,7 @@ In addition, the following network ports must be available: | **SAP Technical Application and Component** | **Port** | | --- | --- | -| **_SAP HANA Sytem Replication_** | | +| **_SAP HANA System Replication_** | | | hdbnameserver
used for log and data shipping from a primary site to a secondary site.
System DB port number plus 10,000 | 4``01 | | hdbnameserver
unencrypted metadata communication between sites.
System DB port number plus 10,000 | 4``02 | | hdbnameserver
used for encrypted metadata communication between sites.
System DB port number plus 10,000 | 4``06 | @@ -95,7 +95,7 @@ In addition, the following network ports must be available: | **_Linux Pacemaker_** | | | pcsd
cluster nodes requirement for node-to-node communication | 2224 (TCP)| | pacemaker
cluster nodes requirement for Pacemaker Remote service daemon | 3121 (TCP) | -| corosync
cluster nodes requirement for node-to-node communcation | 5404-5412 (UDP) | +| corosync
cluster nodes requirement for node-to-node communication | 5404-5412 (UDP) | ## Execution Flow diff --git a/roles/sap_ha_pacemaker_cluster/defaults/main.yml b/roles/sap_ha_pacemaker_cluster/defaults/main.yml index 033ecfdb5..23cfbc8c6 100644 --- a/roles/sap_ha_pacemaker_cluster/defaults/main.yml +++ b/roles/sap_ha_pacemaker_cluster/defaults/main.yml @@ -19,7 +19,7 @@ sap_ha_pacemaker_cluster_system_roles_collection: 'fedora.linux_system_roles' # Optional: write all cluster configuration (including unencrypted credentials!) into a yaml # config file. -# Useful for parameter review or re-use with the 'ha_cluster' LSR. +# Useful for parameter review or reuse with the 'ha_cluster' LSR. sap_ha_pacemaker_cluster_create_config_varfile: false sap_ha_pacemaker_cluster_create_config_dest: "review_resource_config.yml" diff --git a/roles/sap_ha_pacemaker_cluster/tasks/main.yml b/roles/sap_ha_pacemaker_cluster/tasks/main.yml index d2d9b3ccd..7882f1aa3 100644 --- a/roles/sap_ha_pacemaker_cluster/tasks/main.yml +++ b/roles/sap_ha_pacemaker_cluster/tasks/main.yml @@ -10,7 +10,7 @@ # 5. Include LSR "ha_cluster" with the constructed parameters as role arguments # 6. Add solution specific config # * srhook -# 7. Save LSR "ha_cluster" input parameters in .yml file for easy re-use +# 7. Save LSR "ha_cluster" input parameters in .yml file for easy reuse # TODO: Build all resource/constraint configuration variables based on # simpler user input (think: drop-down options in a UI) @@ -214,7 +214,7 @@ # Save all the constructed cluster parameters into a vars file. # -# This will help re-using ha_cluster afterwards without loosing the already +# This will help re-using ha_cluster afterwards without losing the already # configured resources and constraints. # The ha_cluster role will otherwise remove configuration that is not part # of the parameters provided during any subsequent run outside of the current diff --git a/roles/sap_hana_install/README.md b/roles/sap_hana_install/README.md index 42ad2ca06..c81786080 100644 --- a/roles/sap_hana_install/README.md +++ b/roles/sap_hana_install/README.md @@ -267,7 +267,7 @@ These checks are only performed if `sap_hana_install_force` is set to `true`. It - If file `hdblcm` is found, skip the next step and proceed with the `hdblcm` existence check. - - If file `hdblcm` ist not found, proceed with the next step. + - If file `hdblcm` is not found, proceed with the next step. - Prepare SAR files for `hdblcm`: diff --git a/roles/sap_hana_install/defaults/main.yml b/roles/sap_hana_install/defaults/main.yml index 771c566ba..c388228b8 100644 --- a/roles/sap_hana_install/defaults/main.yml +++ b/roles/sap_hana_install/defaults/main.yml @@ -20,7 +20,7 @@ sap_hana_install_software_extract_directory: "{{ sap_hana_install_software_direc # set the value to true. By default, this directory will not be removed sap_hana_install_cleanup_extract_directory: false -# Set this variabe to `yes` if you want to copy the SAR files from `sap_hana_install_software_directory` +# Set this variable to `yes` if you want to copy the SAR files from `sap_hana_install_software_directory` # to `sap_hana_install_software_extract_directory/sarfiles` before extracting. # This might be useful if the SAR files are on a slow fileshare. sap_hana_install_copy_sarfiles: no @@ -59,7 +59,7 @@ sap_hana_install_verify_signature: no sap_hana_install_configfile_directory: "{{ sap_hana_install_software_extract_directory }}/configfiles" # If a custom path for sap_hana_install_configfile_directory was defined and if there is a requirement to cleanup this directory, -# then set "sap_hana_install_cleanup_configfile_directory" as true. Incase if a custom path was not defined and +# then set "sap_hana_install_cleanup_configfile_directory" as true. In case if a custom path was not defined and # "sap_hana_install_cleanup_extract_directory" was set as true, then the configfiles will be removed. sap_hana_install_cleanup_configfile_directory: false diff --git a/roles/sap_hana_install/tasks/assert-addhosts-loop-block.yml b/roles/sap_hana_install/tasks/assert-addhosts-loop-block.yml index 0210a5cf1..72439716a 100644 --- a/roles/sap_hana_install/tasks/assert-addhosts-loop-block.yml +++ b/roles/sap_hana_install/tasks/assert-addhosts-loop-block.yml @@ -10,7 +10,7 @@ msg: "Instance profile: '/hana/shared/{{ sap_hana_install_sid }}/profile/\ {{ sap_hana_install_sid }}_HDB{{ sap_hana_install_number }}_{{ line_item }}'" -- name: SAP HANA Add Hosts - Assert that there is no instance profile for the addional hosts +- name: SAP HANA Add Hosts - Assert that there is no instance profile for the additional hosts ansible.builtin.assert: that: not __sap_hana_install_register_instance_profile_addhost.stat.exists fail_msg: @@ -28,7 +28,7 @@ ansible.builtin.debug: msg: "Instance directory in /usr/sap: '/usr/sap/{{ sap_hana_install_sid }}/HDB{{ sap_hana_install_number }}/{{ line_item }}'" -- name: SAP HANA Add Hosts - Assert that there is no SAP HANA instance directory in '/usr/sap' for the addional hosts +- name: SAP HANA Add Hosts - Assert that there is no SAP HANA instance directory in '/usr/sap' for the additional hosts ansible.builtin.assert: that: not __sap_hana_install_register_usr_sap_instance_directory.stat.exists fail_msg: diff --git a/roles/sap_hana_preconfigure/tasks/RedHat/generic/disable-coredumps.yml b/roles/sap_hana_preconfigure/tasks/RedHat/generic/disable-coredumps.yml index 524f35cb9..a82bb1ada 100644 --- a/roles/sap_hana_preconfigure/tasks/RedHat/generic/disable-coredumps.yml +++ b/roles/sap_hana_preconfigure/tasks/RedHat/generic/disable-coredumps.yml @@ -2,7 +2,7 @@ # Reasons for noqa: 1. Tabs can increase readability; # 2. The example in man limits.conf is tab formatted; -# 3. It is difficult to replace tabs by spaces for entries for which their lenghts are not known +# 3. It is difficult to replace tabs by spaces for entries for which their lengths are not known - name: Disable core file creation for all users # noqa no-tabs ansible.builtin.lineinfile: path: /etc/security/limits.d/99-sap.conf diff --git a/roles/sap_hana_preconfigure/tasks/sapnote/2009879.yml b/roles/sap_hana_preconfigure/tasks/sapnote/2009879.yml index 130ba5111..a3c35f2fa 100644 --- a/roles/sap_hana_preconfigure/tasks/sapnote/2009879.yml +++ b/roles/sap_hana_preconfigure/tasks/sapnote/2009879.yml @@ -7,7 +7,7 @@ # We include the release specific stuff here # -# Todo: move repo checking to RedHat/installion.yml +# Todo: move repo checking to RedHat/installation.yml # Disable for now, as there is no support for ppc64le #- name: Check for EUS or E4S repository # shell: | @@ -31,8 +31,7 @@ - name: Configure - Display SAP note number 2009879 and its version ansible.builtin.debug: msg: "SAP note {{ (__sap_hana_preconfigure_sapnotes_versions | selectattr('number', 'match', '^2009879$') | first).number }} - (version {{ (__sap_hana_preconfigure_sapnotes_versions | selectattr('number', 'match', '^2009879$') | first).version }}): SAP HANA Guidelines for R -HEL 7 (pdf)" + (version {{ (__sap_hana_preconfigure_sapnotes_versions | selectattr('number', 'match', '^2009879$') | first).version }}): SAP HANA Guidelines for RHEL 7 (pdf)" - name: Include 2009879_X.yml ansible.builtin.include_tasks: 2009879_{{ ansible_distribution_major_version }}.yml diff --git a/roles/sap_hana_preconfigure/vars/RedHat_8.yml b/roles/sap_hana_preconfigure/vars/RedHat_8.yml index 82f048a3e..5b77385af 100644 --- a/roles/sap_hana_preconfigure/vars/RedHat_8.yml +++ b/roles/sap_hana_preconfigure/vars/RedHat_8.yml @@ -192,7 +192,7 @@ __sap_hana_preconfigure_min_pkgs: "{{ lookup('vars', '__sap_hana_preconfigure_mi __sap_hana_preconfigure_packages: # SAP NOTE 2772999: - expect -# package graphwiz: graph visualization toos, for supportability) +# package graphwiz: graph visualization tools, for supportability) - graphviz # package iptraf-ng: TCP/IP network monitor, for supportability) - iptraf-ng @@ -231,7 +231,7 @@ __sap_hana_preconfigure_packages: __sap_hana_preconfigure_packages_min_install: # SAP NOTE 2772999: - expect -# package graphwiz: graph visualization toos, for supportability) +# package graphwiz: graph visualization tools, for supportability) # - graphviz # package iptraf-ng: TCP/IP network monitor, for supportability) # - iptraf-ng diff --git a/roles/sap_hana_preconfigure/vars/RedHat_9.yml b/roles/sap_hana_preconfigure/vars/RedHat_9.yml index 68d2bb691..2eaa8ed3d 100644 --- a/roles/sap_hana_preconfigure/vars/RedHat_9.yml +++ b/roles/sap_hana_preconfigure/vars/RedHat_9.yml @@ -198,7 +198,7 @@ __sap_hana_preconfigure_packages: # package libxcrypt-compat: needed SAP HANA and also by sapstartsrv on RHEL 9: # - libxcrypt-compat # now installed by role sap_general_preconfigure, see also SAP note 3108316, version 4. # For support purposes: -# package graphwiz: graph visualization toos, for supportability) +# package graphwiz: graph visualization tools, for supportability) - graphviz # package iptraf-ng: TCP/IP network monitor, for supportability) - iptraf-ng @@ -226,7 +226,7 @@ __sap_hana_preconfigure_packages_min_install: # required for SAP HANA on RHEL 9: - libxcrypt-compat # For support purposes: -# package graphwiz: graph visualization toos, for supportability) +# package graphwiz: graph visualization tools, for supportability) # - graphviz # package iptraf-ng: TCP/IP network monitor, for supportability) # - iptraf-ng diff --git a/roles/sap_hostagent/CONTRIBUTING.md b/roles/sap_hostagent/CONTRIBUTING.md index 5350483e8..8f5bcb523 100644 --- a/roles/sap_hostagent/CONTRIBUTING.md +++ b/roles/sap_hostagent/CONTRIBUTING.md @@ -26,10 +26,10 @@ According to SAP Note the command is: saphostexec -upgrade - get the installable Version - install/upgrade if required -### Important Steps from the documention: +### Important Steps from the documentation: - requires root - - Optional Paramter: `-pf ` defaults to /usr/sap/exe + - Optional Parameter: `-pf ` defaults to /usr/sap/exe 1. Install Host agent (from unpacked directory) ``` diff --git a/roles/sap_hostagent/README.md b/roles/sap_hostagent/README.md index 50132e720..13aa84fa4 100644 --- a/roles/sap_hostagent/README.md +++ b/roles/sap_hostagent/README.md @@ -48,7 +48,7 @@ It is also important that your disks are setup according to the [SAP storage req |sap_hostagent_rpm_remote_path|Local directory path where RPM file is located|yes, unless `sap_hostagent_rpm_local_path` is used| |sap_hostagent_rpm_file_name|Local RPM file name|yes| |sap_hostagent_agent_tmp_directory|Temporary directory path that will be created on the target host|no (defaulted in the role)| -|sap_hostagent_clean_tmp_directory|Boolean variable to indicate if the temporary directory will be removed or not afer the installation| no (defaulted in the role)| +|sap_hostagent_clean_tmp_directory|Boolean variable to indicate if the temporary directory will be removed or not after the installation| no (defaulted in the role)| ### SAR based installations (content on ansible control node) @@ -60,7 +60,7 @@ It is also important that your disks are setup according to the [SAP storage req |sap_hostagent_sapcar_local_path|Local directory path where SAPCAR tool file is located|yes| |sap_hostagent_sapcar_file_name|Local SAPCAR tool file name|yes| |sap_hostagent_agent_tmp_directory|Temporary directory path that will be created on the target host|no (defaulted in the role)| -|sap_hostagent_clean_tmp_directory|Boolean variable to indicate if the temporary directory will be removed or not afer the installation| no (defaulted in the role)| +|sap_hostagent_clean_tmp_directory|Boolean variable to indicate if the temporary directory will be removed or not after the installation| no (defaulted in the role)| ### SAR based installations (with content existing on target node) @@ -72,7 +72,7 @@ It is also important that your disks are setup according to the [SAP storage req |sap_hostagent_sapcar_remote_path|Remote directory path of SAR archive|yes| |sap_hostagent_sapcar_file_name|Remote file name of SAR archive|yes| |sap_hostagent_agent_tmp_directory|Temporary directory path that will be created on the target host|no (defaulted in the role)| -|sap_hostagent_clean_tmp_directory|Boolean variable to indicate if the temporary directory will be removed or not afer the installation| no (defaulted in the role)| +|sap_hostagent_clean_tmp_directory|Boolean variable to indicate if the temporary directory will be removed or not after the installation| no (defaulted in the role)| ### SAP Bundle based installations @@ -82,7 +82,7 @@ It is also important that your disks are setup according to the [SAP storage req |sap_hostagent_installation_type|Source type of the installation for SAPHOSTAGENT|yes with `bundle` value| |sap_hostagent_bundle_path|Target host directory path where SAP Installation Bundle has been unarchived| |sap_hostagent_agent_tmp_directory|Temporary directory path that will be created on the target host|no (defaulted in the role)| -|sap_hostagent_clean_tmp_directory|Boolean variable to indicate if the temporary directory will be removed or not afer the installation| no (defaulted in the role)| +|sap_hostagent_clean_tmp_directory|Boolean variable to indicate if the temporary directory will be removed or not after the installation| no (defaulted in the role)| ### SSL Configuration @@ -99,7 +99,7 @@ Right now the role will configure the PSE and create a CSR. Adding signed certif Before using this role ensure your system has been configured properly to run SAP applications. -You can use the supported role `sap_general_preconfigure` comming with RHEL 7 and 8 with RHEL for SAP Solutions Subscription +You can use the supported role `sap_general_preconfigure` coming with RHEL 7 and 8 with RHEL for SAP Solutions Subscription The upstream version of this role can be found [here](https://github.com/linux-system-roles/sap_general_preconfigure) diff --git a/roles/sap_hostagent/tasks/config_ssl.yml b/roles/sap_hostagent/tasks/config_ssl.yml index 0e6bcbb1f..3cdb5510c 100644 --- a/roles/sap_hostagent/tasks/config_ssl.yml +++ b/roles/sap_hostagent/tasks/config_ssl.yml @@ -57,7 +57,7 @@ register: ssl_config_output changed_when: "'Added SSO-credentials for PSE' in ssl_config_output.stdout" -# Right now there is no option to import teh signed certificate. The CSR must be signed +# Right now there is no option to import the signed certificate. The CSR must be signed # by a valid CA in order to import it # # - name: Import the signed certificate into the server PSE diff --git a/roles/sap_hypervisor_node_preconfigure/README.md b/roles/sap_hypervisor_node_preconfigure/README.md index 74e72a487..2dfe015d0 100644 --- a/roles/sap_hypervisor_node_preconfigure/README.md +++ b/roles/sap_hypervisor_node_preconfigure/README.md @@ -58,7 +58,7 @@ sap_hypervisor_node_preconfigure_ignore_minimal_memory_check: True|False # sap_hypervisor_node_preconfigure_cluster_config.worker_localstorage_device: /dev/sdb sap_hypervisor_node_preconfigure_install_hpp: True|False ``` -The following variables are describing the nodes and networks to be used. It can make sense to have them in a seperate file, e.g. see `playbooks/vars/sample-variables-sap-hypervisor-node-preconfigure-rh_ocp_virt.yml` for an example. +The following variables are describing the nodes and networks to be used. It can make sense to have them in a separate file, e.g. see `playbooks/vars/sample-variables-sap-hypervisor-node-preconfigure-rh_ocp_virt.yml` for an example. ``` sap_hypervisor_node_preconfigure_cluster_config: # URL under which the OCP cluster is reachable diff --git a/roles/sap_install_media_detect/README.md b/roles/sap_install_media_detect/README.md index d936b39bd..23dfaa60c 100644 --- a/roles/sap_install_media_detect/README.md +++ b/roles/sap_install_media_detect/README.md @@ -3,7 +3,7 @@ Ansible Role for detection and extraction of SAP Software installation media This role is used to prepare for installation of SAP Software, by searching a given directory for SAP installation media (e.g. SAR files), -moving files to subdirectories (i.e. `/sap_hana` and `/sap_swpm`) with the directory/file ownership permissons, then extracting the detected files. +moving files to subdirectories (i.e. `/sap_hana` and `/sap_swpm`) with the directory/file ownership permissions, then extracting the detected files. Detection of installation media is available for SAP HANA and the various key installation files when using SAP SWPM to install SAP Business Applications based upon SAP NetWeaver (e.g. SAP S/4HANA, SAP BW/4HANA, SAP ECC, SAP BW, SAP WebDispatcher etc). diff --git a/roles/sap_install_media_detect/tasks/prepare/enable_rar_handling.yml b/roles/sap_install_media_detect/tasks/prepare/enable_rar_handling.yml index 774154ac7..a829654ab 100644 --- a/roles/sap_install_media_detect/tasks/prepare/enable_rar_handling.yml +++ b/roles/sap_install_media_detect/tasks/prepare/enable_rar_handling.yml @@ -74,7 +74,7 @@ - name: SAP Install Media Detect - Prepare - Install a rar extractor package (no EPEL) - when: sap_install_media_detect_rar_package != 'EPEL' # When default is overriden + when: sap_install_media_detect_rar_package != 'EPEL' # When default is overridden block: - name: SAP Install Media Detect - Prepare - rar extractor - Set facts diff --git a/roles/sap_install_media_detect/tasks/prepare/move_files_to_main_directory.yml b/roles/sap_install_media_detect/tasks/prepare/move_files_to_main_directory.yml index cab0f1e1c..e831c2a08 100644 --- a/roles/sap_install_media_detect/tasks/prepare/move_files_to_main_directory.yml +++ b/roles/sap_install_media_detect/tasks/prepare/move_files_to_main_directory.yml @@ -50,7 +50,7 @@ - "{{ __sap_install_media_detect_register_find_result_phase_1b.results }}" - files -# Reason for noqa: Too much additional code required for determing if anything has changed or not +# Reason for noqa: Too much additional code required for determinig if anything has changed or not - name: SAP Install Media Detect - Prepare - Move files back to '{{ __sap_install_media_detect_software_main_directory }}' # noqa no-changed-when ansible.builtin.command: "mv {{ line_item }} {{ __sap_install_media_detect_software_main_directory }}/" loop: "{{ __sap_install_media_detect_fact_find_result_phase_1b }}" diff --git a/roles/sap_maintain_etc_hosts/README.md b/roles/sap_maintain_etc_hosts/README.md index 3bae801cc..98fab9adf 100644 --- a/roles/sap_maintain_etc_hosts/README.md +++ b/roles/sap_maintain_etc_hosts/README.md @@ -11,7 +11,7 @@ Requirements ## Role Input Parameters -This role requires the dictonary `sap_maintain_etc_hosts_list` which contains the parameters for the hostfile. The default value is the definition of the cluster nodes like in the role `sap_ha_pacemaker_cluster`. If the value `sap_hana_cluster_nodes`or `sap_ha_pacemaker_cluster_cluster_nodes` is not defined the role creates a default value from `ansible_facts`. +This role requires the dictionary `sap_maintain_etc_hosts_list` which contains the parameters for the hostfile. The default value is the definition of the cluster nodes like in the role `sap_ha_pacemaker_cluster`. If the value `sap_hana_cluster_nodes`or `sap_ha_pacemaker_cluster_cluster_nodes` is not defined the role creates a default value from `ansible_facts`. Caution: If you want to use this role to remove entries from /etc/hosts it is a good practise to do this before adding entries. The adding/removal is done in the order the entries are listed. diff --git a/roles/sap_maintain_etc_hosts/meta/argument_specs.yml b/roles/sap_maintain_etc_hosts/meta/argument_specs.yml index 8cd8bd07b..4244e41ed 100644 --- a/roles/sap_maintain_etc_hosts/meta/argument_specs.yml +++ b/roles/sap_maintain_etc_hosts/meta/argument_specs.yml @@ -29,7 +29,7 @@ argument_specs: type: str description: - Domainname of the node - - _Optional. Defaults to sap_domain, if set, otherise ansible_domain is the default_ + - _Optional. Defaults to sap_domain, if set, otherwise ansible_domain is the default_ - _Optional. when deleting a node use only when node_name is defined_ aliases: type: list diff --git a/roles/sap_maintain_etc_hosts/tasks/main.yml b/roles/sap_maintain_etc_hosts/tasks/main.yml index ac1e0a18f..c24cdebe4 100644 --- a/roles/sap_maintain_etc_hosts/tasks/main.yml +++ b/roles/sap_maintain_etc_hosts/tasks/main.yml @@ -1,6 +1,6 @@ --- # tasks file for sap_maintain_etc_hosts -#- name: Double check that list entries with state present do not have duplicate IP adresses +#- name: Double check that list entries with state present do not have duplicate IP addresses # ansible.builtin.assert: # that: # - {{ sap_maintain_etc_hosts_list | selectattr('state') }} diff --git a/roles/sap_maintain_etc_hosts/tasks/update_host_absent.yml b/roles/sap_maintain_etc_hosts/tasks/update_host_absent.yml index f4767fa0a..dddf8f467 100644 --- a/roles/sap_maintain_etc_hosts/tasks/update_host_absent.yml +++ b/roles/sap_maintain_etc_hosts/tasks/update_host_absent.yml @@ -2,10 +2,10 @@ - name: Verify that variable node_ip is in the correct format ansible.builtin.assert: that: thishost.node_ip is ansible.utils.ip - msg: "Variable 'node_ip' is not an IP adress. Please use the correct format" + msg: "Variable 'node_ip' is not an IP address. Please use the correct format" when: thisnode.node_ip is defined -- name: Ensure that either IP adress or hostname is defined +- name: Ensure that either IP address or hostname is defined ansible.builtin.assert: that: > ((thishost.node_ip is defined) and (thishost.node_name is undefined) and (thishost.node_domain is undefined)) or diff --git a/roles/sap_maintain_etc_hosts/tasks/update_host_present.yml b/roles/sap_maintain_etc_hosts/tasks/update_host_present.yml index a46480239..54714284c 100644 --- a/roles/sap_maintain_etc_hosts/tasks/update_host_present.yml +++ b/roles/sap_maintain_etc_hosts/tasks/update_host_present.yml @@ -7,7 +7,7 @@ - name: Verify that variable node_ip is in the correct format ansible.builtin.assert: that: thishost.node_ip is ansible.utils.ip - msg: "Variable 'node_ip' is not an IP adress. Please use the correct format" + msg: "Variable 'node_ip' is not an IP address. Please use the correct format" - name: Verify that variable node_name is set ansible.builtin.assert: diff --git a/roles/sap_maintain_etc_hosts/tests/README.md b/roles/sap_maintain_etc_hosts/tests/README.md index 879857a2b..02fff336d 100644 --- a/roles/sap_maintain_etc_hosts/tests/README.md +++ b/roles/sap_maintain_etc_hosts/tests/README.md @@ -6,7 +6,7 @@ to create a test file in the host file format, like the following: ```[bash] $ cat ./test.hostsfile 127.0.0.1 localhost host1 localhost.localdomain host1.abc.de -1.2.3.5 thishost.to.be.deleteted +1.2.3.5 thishost.to.be.deleted 1.2.3.6 host2 ``` diff --git a/roles/sap_netweaver_preconfigure/defaults/main.yml b/roles/sap_netweaver_preconfigure/defaults/main.yml index dbd6bf16c..e2f09cae6 100644 --- a/roles/sap_netweaver_preconfigure/defaults/main.yml +++ b/roles/sap_netweaver_preconfigure/defaults/main.yml @@ -26,6 +26,6 @@ sap_netweaver_preconfigure_saptune_version: '3.0.2' #S4HANA-APP+DB #S4HANA-APPSERVER #S4HANA-DBSERVER -# The default vaule is NETWEAVER +# The default value is NETWEAVER sap_netweaver_preconfigure_saptune_solution: 'NETWEAVER' diff --git a/roles/sap_storage_setup/README.md b/roles/sap_storage_setup/README.md index d30109f09..4c4e12746 100644 --- a/roles/sap_storage_setup/README.md +++ b/roles/sap_storage_setup/README.md @@ -104,7 +104,7 @@ Describes the filesystems to be configured.
- **nfs_server**
When defining an NFS filesystem, this is the address of the NFS server.
The address must contain the root path, in which the mount directories exist or will be created.
For example, `192.168.1.100:/`. - **swap_path**
- The path to the swap file.
When this option is defined for a swap filesystem definition, it will create a swap file on an existing filesytem. + The path to the swap file.
When this option is defined for a swap filesystem definition, it will create a swap file on an existing filesystem. Example: diff --git a/roles/sap_storage_setup/meta/argument_specs.yml b/roles/sap_storage_setup/meta/argument_specs.yml index 298fb2a47..55fe57cbb 100644 --- a/roles/sap_storage_setup/meta/argument_specs.yml +++ b/roles/sap_storage_setup/meta/argument_specs.yml @@ -131,7 +131,7 @@ argument_specs: swap_path: description: - The path to the swap file. - - When this option is defined for a swap filesystem definition, it will create a swap file on an existing filesytem. + - When this option is defined for a swap filesystem definition, it will create a swap file on an existing filesystem. type: str diff --git a/roles/sap_swpm/README.md b/roles/sap_swpm/README.md index 7bcb5f54e..f8a16e789 100644 --- a/roles/sap_swpm/README.md +++ b/roles/sap_swpm/README.md @@ -16,7 +16,7 @@ This role has been tested and working for the following scenarios - Dual Host Installation - Distributed Installation - System Restore -- High Avalability Installation +- High Availability Installation This role has been tested and working for the following SAP products - SAP S/4HANA 1809, 1909, 2020, 2021 diff --git a/roles/sap_swpm/tasks/pre_install/create_os_user.yml b/roles/sap_swpm/tasks/pre_install/create_os_user.yml index ccf72e132..397f81fa5 100644 --- a/roles/sap_swpm/tasks/pre_install/create_os_user.yml +++ b/roles/sap_swpm/tasks/pre_install/create_os_user.yml @@ -44,7 +44,7 @@ recurse: yes mode: '0755' -# - name: SAP SWPM Pre Install - Purge parameters so it wont populate inifile.params to prevent SWPM from crashing +# - name: SAP SWPM Pre Install - Purge parameters so it will not populate inifile.params to prevent SWPM from crashing # ansible.builtin.set_facts: # sap_swpm_sapadm_uid: "" # sap_swpm_sapsys_gid: "" diff --git a/roles/sap_vm_preconfigure/defaults/main.yml b/roles/sap_vm_preconfigure/defaults/main.yml index 7835abe27..45de6c6fc 100644 --- a/roles/sap_vm_preconfigure/defaults/main.yml +++ b/roles/sap_vm_preconfigure/defaults/main.yml @@ -1,9 +1,9 @@ --- -# For setting Ansible Var sap_vm_platform, unless overriden +# For setting Ansible Var sap_vm_platform, unless overridden sap_vm_platform_detect: false -# For re-use of this Ansible Role to establish which platform, without running any of the preconfigure Ansible Tasks for that platform +# For reuse of this Ansible Role to establish which platform, without running any of the preconfigure Ansible Tasks for that platform sap_vm_platform_detect_only: false # Static definition, required if detection boolean is set to false diff --git a/tools/swpm2_parameters_inifile_generate.py b/tools/swpm2_parameters_inifile_generate.py index aea54fae2..af8d4a24b 100755 --- a/tools/swpm2_parameters_inifile_generate.py +++ b/tools/swpm2_parameters_inifile_generate.py @@ -117,7 +117,7 @@ def control_xml_to_inifile_params(filepath): # # All parameters are commented-out, each hash # before the parameter is removed to activate the parameter. # When running SWPM in Unattended Mode, the activated parameters will create a new SWPM file in the sapinst directory. - # If any parameter is marked as 'encode', the plaintext value will be coverted to DES hash for this parameter + # If any parameter is marked as 'encode', the plaintext value will be converted to DES hash for this parameter # in the new SWPM file (in the sapinst directory). # # An inifile.params is otherwise obtained after running SWPM as GUI or Unattended install, @@ -151,7 +151,7 @@ def control_xml_to_inifile_params(filepath): if component_parameter_key_inifile_name is not None: inifile_output.write("\n# %s" % (component_parameter_contents_doclong_text)) if component_parameter_key_encode == "true": - inifile_output.write("\n# Encoded parameter. Plaintext values will be coverted to DES hash") + inifile_output.write("\n# Encoded parameter. Plaintext values will be converted to DES hash") inifile_output.write("\n# %s = %s\n" % (component_parameter_key_inifile_name, component_parameter_key_defval)) inifile_output.close()