Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sap_general_preconfigure: use tags instead of role parameters for limiting the role scope #342

Closed
berndfinger opened this issue Mar 13, 2023 · 1 comment
Closed

sap_general_preconfigure: use tags instead of role parameters for limiting the role scope #342

berndfinger opened this issue Mar 13, 2023 · 1 comment
Assignees
@berndfinger
Labels
enhancement New feature or request

Comments

@berndfinger
Copy link
Member

We can use apply: to promote tags to tasks in dynamically included files, like in

community.sap_install/roles/sap_swpm/tasks/pre_install.yml

Line 33 in fa606d9

- name: SAP SWPM Pre Install - Firewall Setup

Advantages:

  1. Get rid of many parameters
  2. Introduce the ability to skip one or more steps of SAP notes without having to specify the remaining steps
@berndfinger berndfinger self-assigned this Mar 13, 2023
@berndfinger berndfinger mentioned this issue Mar 13, 2023
Open
@berndfinger berndfinger added the enhancement New feature or request label Mar 13, 2023
@berndfinger berndfinger mentioned this issue Mar 13, 2023
Open
berndfinger added a commit to berndfinger/community.sap_install that referenced this issue Feb 9, 2024
@berndfinger
sap_general_preconfigure: implement tags
d0a0743 
... for limiting the role scope.

Relates to sap-linuxlab#342.

Sample playbook calls:

$ ansible-playbook sap.yml --tags \
sap_general_preconfigure_configuration,sap_general_preconfigure_configuration_all_steps

$ ansible-playbook sap.yml --tags \
sap_general_preconfigure_configuration,sap_general_preconfigure_2772999_02

$ ansible-playbook sap.yml --tags \
sap_general_preconfigure_configuration,sap_general_preconfigure_selinux

$ ansible-playbook sap.yml --tags \
sap_general_preconfigure_configuration,sap_general_preconfigure_configuration_all_steps \
--skip-tags sap_general_preconfigure_2772999_02

$ ansible-playbook sap.yml --tags \
sap_general_preconfigure_configuration,sap_general_preconfigure_configuration_all_steps \
--skip-tags sap_general_preconfigure_selinux

Signed-off-by: Bernd Finger <[email protected]>
berndfinger added a commit to berndfinger/community.sap_install that referenced this issue Feb 12, 2024
@berndfinger
sap_general_preconfigure: add more fine-grained tags
7194d55 
Part of sap-linuxlab#342.

Signed-off-by: Bernd Finger <[email protected]>
berndfinger added a commit to berndfinger/community.sap_install that referenced this issue Feb 12, 2024
@berndfinger
sap_general_preconfigure: optimize tags; adapt README.md
f828b4c 
Solves sap-linuxlab#342.

Signed-off-by: Bernd Finger <[email protected]>
berndfinger added a commit to berndfinger/community.sap_install that referenced this issue Feb 12, 2024
@berndfinger
sap_general_preconfigure: Add more examples to README.md
c653640 
Relates to sap-linuxlab#342.

Signed-off-by: Bernd Finger <[email protected]>
@berndfinger berndfinger mentioned this issue Feb 12, 2024
Merged
berndfinger added a commit to berndfinger/community.sap_install that referenced this issue Feb 12, 2024
@berndfinger
sap_general_preconfigure: Clarify the scope of tags in README.md
c2cd1a4 
Relates to: sap-linuxlab#342.

Signed-off-by: Bernd Finger <[email protected]>
berndfinger added a commit to berndfinger/community.sap_install that referenced this issue Feb 16, 2024
@berndfinger
sap_general_preconfigure: Use only one tag for running all configurat…
7e08d48 
…ion steps

Examples for using tags: See README.md.

Relates to: sap-linuxlab#342.

Signed-off-by: Bernd Finger <[email protected]>
berndfinger added a commit to berndfinger/community.sap_install that referenced this issue Feb 27, 2024
@berndfinger
sap_general_preconfigure: Fix some obvious errors
f84f9d3 
Relates to issue sap-linuxlab#342.

Signed-off-by: Bernd Finger <[email protected]>
berndfinger added a commit to berndfinger/community.sap_install that referenced this issue Feb 28, 2024
@berndfinger
sap_general_preconfigure: Add global SAP note tags
740ba0b 
relates to issue sap-linuxlab#342

Signed-off-by: Bernd Finger <[email protected]>
berndfinger added a commit to berndfinger/community.sap_install that referenced this issue Feb 28, 2024
@berndfinger
sap_general_preconfigure: Adapt README.md
63bf621 
Relates to issue sap-linuxlab#342

Signed-off-by: Bernd Finger <[email protected]>
@berndfinger
Copy link
Member Author

Solved in PR #653.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@berndfinger berndfinger

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@berndfinger