Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sap_maintain_etc_hosts: no longer use the ansible.utils.ip test #667

Closed
berndfinger opened this issue Feb 29, 2024 · 2 comments
Closed

sap_maintain_etc_hosts: no longer use the ansible.utils.ip test #667

berndfinger opened this issue Feb 29, 2024 · 2 comments
Assignees
@berndfinger

Comments

@berndfinger
Copy link
Member

We should avoid using non-ansible.builtin code wherever possible so we reduce the number of dependencies.
@berndfinger berndfinger self-assigned this Feb 29, 2024
@berndfinger
Copy link
Member Author

The source of the ansible.utils.ip test is here: https://github.com/ansible-collections/ansible.utils/blob/main/plugins/test/ip.py

@berndfinger berndfinger changed the title sap_maintain_etc_hosts: no longer use the ansible.utils.ip filter sap_maintain_etc_hosts: no longer use the ansible.utils.ip test Feb 29, 2024
berndfinger added a commit to berndfinger/community.sap_install that referenced this issue Feb 29, 2024
@berndfinger
sap_maintain_etc_hosts: no longer use ansible.utils.ip
0e9b7e5 
Checking the ip address against a regex pattern should be sufficient to
ensure valid IP addresses are passed to the role.

Solves issue sap-linuxlab#667.

Signed-off-by: Bernd Finger <[email protected]>
@berndfinger berndfinger mentioned this issue Feb 29, 2024
Merged
berndfinger added a commit to berndfinger/community.sap_install that referenced this issue Feb 29, 2024
@berndfinger
sap_maintain_etc_hosts: use the regex method also for assert
8b8748f 
Relates to sap-linuxlab#667.

Signed-off-by: Bernd Finger <[email protected]>
@berndfinger
Copy link
Member Author

Closed by #669.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@berndfinger berndfinger

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@berndfinger