ensure prune rework #224
Merged
ensure prune rework #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 36ed4a3.
Carthaca
requested review from
chuan137,
kpawar-sap,
sumitarora2786 and
crenduchinta88
as code owners
Carthaca
force-pushed
the
ensure_prune_rework
branch
2 times, most recently
from
cce3759 to
b7ed10e
Compare
|
looks good. py3 test failing - manila.tests.share.drivers.netapp.dataontap.cluster_mode.test_lib_base.NetAppFileStorageLibraryTestCase.test_start_periodic_tasks once fixed good to merge. |
Same like ensure, we only execute the housekeeping if we invoke the service with the reexport flag. We keep the original timing, i.e. run these every 600 seconds. Change-Id: Ia58e3de56bc0e903a3d2886a2bdf52dc0fdf30c4
Carthaca
force-pushed
the
ensure_prune_rework
branch
from
b7ed10e to
518f6b7
Compare
|
tests have been fixed |
kpawar-sap
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we need the shorter interval for housekeeping.
E.g. prune deleted volumes needs several runs to get rid of volumes with clones:
So it is good that this runs every 10 minutes, otherwise we would be stuck with with volumes to cleanup for too long.
Also have a look at internal issue # 78 - our force delete logic is flawed for such volumes, too, which also adds up to the time until those are deleted..