You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Spy UI component relies on the "href" menu link attribute, yet it is barely used with angular, as angular-ui-router replace it with a "ui-sref" and the basic router with a "ng-href" that possess their own behaviour.
It seems that line 61 of the file /src/js/Ink/UI/Spy/1/lib.js the href is hardcoded.
That might not be hard to use a variable instead (with of course "href" as the default), and allow developper to add a "data-spied" facultative attribute on the link itself.
That would give this kind of code :
`
link
Blah`
More broadly any component reliying on a specific html attribute might break using Angular, which makes Ink integration a bit tricky.
The text was updated successfully, but these errors were encountered:
Hi @eric-burel, that seems like a perfectly good idea and make Ink a better playmate for other libs. I'll check the code out and try to have a fix for it in the next release.
Hello,
The Spy UI component relies on the "href" menu link attribute, yet it is barely used with angular, as angular-ui-router replace it with a "ui-sref" and the basic router with a "ng-href" that possess their own behaviour.
It seems that line 61 of the file /src/js/Ink/UI/Spy/1/lib.js the href is hardcoded.
That might not be hard to use a variable instead (with of course "href" as the default), and allow developper to add a "data-spied" facultative attribute on the link itself.
That would give this kind of code :
`
More broadly any component reliying on a specific html attribute might break using Angular, which makes Ink integration a bit tricky.
The text was updated successfully, but these errors were encountered: