Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular and scroll Spy : hardcoded href attribute #464

Open
eric-burel opened this issue Feb 9, 2016 · 1 comment
Open

Angular and scroll Spy : hardcoded href attribute #464

eric-burel opened this issue Feb 9, 2016 · 1 comment

Comments

@eric-burel
Copy link

Hello,

The Spy UI component relies on the "href" menu link attribute, yet it is barely used with angular, as angular-ui-router replace it with a "ui-sref" and the basic router with a "ng-href" that possess their own behaviour.

It seems that line 61 of the file /src/js/Ink/UI/Spy/1/lib.js the href is hardcoded.
That might not be hard to use a variable instead (with of course "href" as the default), and allow developper to add a "data-spied" facultative attribute on the link itself.

That would give this kind of code :
`

  • link
  • Blah
    `

    More broadly any component reliying on a specific html attribute might break using Angular, which makes Ink integration a bit tricky.

    @pedrocorreia
    Copy link
    Contributor

    Hi @eric-burel, that seems like a perfectly good idea and make Ink a better playmate for other libs. I'll check the code out and try to have a fix for it in the next release.

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    No branches or pull requests

    2 participants