Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow prefetch with IntermediateM2MField #45

Merged
merged 3 commits into from
Oct 4, 2024
Merged

Allow prefetch with IntermediateM2MField #45

merged 3 commits into from
Oct 4, 2024

Conversation

Eg0ra
Copy link
Contributor

@Eg0ra Eg0ra commented Oct 1, 2024 •
edited
Loading

Remove M2MField since import_export.fields.Field supports m2m_add
Improve IntermediateManyToManyField to make prefetch_related works with through model

@Eg0ra Eg0ra self-assigned this Oct 1, 2024
@coveralls
Copy link

coveralls commented Oct 1, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11172914979

Details

  • 15 of 15 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+1.9%) to 82.822%
Totals Coverage Status
Change from base Build 11172852920: 1.9%
Covered Lines: 1268
Relevant Lines: 1531
💛 - Coveralls

@Eg0ra Eg0ra force-pushed the feature/allow-prefetch-related-for-m2m-field branch 2 times, most recently from de095aa to 1708af6 Compare October 2, 2024 03:57
@Eg0ra Eg0ra marked this pull request as ready for review October 2, 2024 04:10
TheSuperiorStanislav
TheSuperiorStanislav approved these changes Oct 2, 2024
View reviewed changes
Copy link
Member

@TheSuperiorStanislav TheSuperiorStanislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did this logic already have tests? If not let's add it

@Eg0ra Eg0ra requested a review from NikAzanov October 3, 2024 05:59
NikAzanov
NikAzanov approved these changes Oct 3, 2024
View reviewed changes
tests/test_models/test_fields.py Outdated Show resolved Hide resolved
tests/test_models/test_fields.py Outdated Show resolved Hide resolved
@Eg0ra Eg0ra force-pushed the feature/allow-prefetch-related-for-m2m-field branch 4 times, most recently from 3221aa3 to 5de68f5 Compare October 3, 2024 06:39
OttoAndrey
OttoAndrey approved these changes Oct 4, 2024
View reviewed changes
tests/test_models/test_fields.py Outdated Show resolved Hide resolved
@Eg0ra Eg0ra force-pushed the feature/allow-prefetch-related-for-m2m-field branch from 5de68f5 to bd0a8ec Compare October 4, 2024 02:25
@Eg0ra Eg0ra merged commit 190376c into main Oct 4, 2024
27 checks passed
@Eg0ra Eg0ra deleted the feature/allow-prefetch-related-for-m2m-field branch October 4, 2024 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NikAzanov NikAzanov NikAzanov approved these changes

@TheSuperiorStanislav TheSuperiorStanislav TheSuperiorStanislav approved these changes

@OttoAndrey OttoAndrey OttoAndrey approved these changes

Assignees

@Eg0ra Eg0ra

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Eg0ra @coveralls @OttoAndrey @TheSuperiorStanislav @NikAzanov