Add specs for deprecated function names #1932
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 17, 2023
Goodwine
reviewed
Aug 18, 2023
| Naming a Sass function "round" is deprecated because it conflicts with the new | ||
| CSS round() syntax. Either rename it or use the math.round() function. | ||
|
|
||
| More info: https:/sass-lang.com/d/math-fn-name |
There was a problem hiding this comment.
Already commented on dart-sass, but this is missing a slash after https:
connorskees
reviewed
Aug 25, 2023
There was a problem hiding this comment.
Perhaps this case is considered too exceptional, but is it worth adding tests for functions which are renamed to these newly reserved functions?
For example:
// foo.scss
@use "bar" as *;
a {
color: round();
}
// bar.scss
@forward "baz" as r*;
// baz.scss
@function ound() { @return 0 }Which today will compile without error, but in the future will fail (as it currently does for a similar setup with e.g. calc).
I had thought it was easier to rename identifiers for some reason -- i.e. without the use of @forward, but I can't think of any concrete way off the top of my head.
|
Closing this out in favor of the approach described in sass/sass#3661 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #1899
See sass/sass#3504
[skip dart-sass]