fix: (IAC-1162) AWS warns of misconfigured EFS mounts

[dhoucgitter]

Changes

• Define the set of AWS EFS best practice NFS mount options to apply with nfs-subdir-external-provisioner baseline tasks
• Use the EFS mount options when EFS storage is present with the aws provider, leave NFS mount options as is for all other storage options
• Add setting fact for STORAGE_TYPE_BACKEND from tfstate when defined in order to select the EFS mount options

Tests

Scenario	Provider	storage_type_backend	Cadence	DAC NFS mount options include noresvport	Notes
1	aws	efs	stable.2023.09	yes	Successful deployment, all pods Running and stable
2	aws	nfs	n/a	no	DAC baseline verified to use existing NFS mount options
3	aws	ontap	n/a	no	DAC baseline verified to use existing NFS mount options
4	azure	n/a	n/a	no	DAC baseline verified to use existing NFS mount options, no unexpected behavior when STORAGE_TYPE_BACKEND is not defined and NOT using aws provider

[thpang]

Is this one really required? As hard states that if the item being mount is not their it will wait forever until that mount point is available. Where soft will simply try and if it fails it'll continue and request the mount when its needed. Just making sure.

[dhoucgitter]

@thpang it doesn't seem like that one is mandatory. The list of options I included came from the AWS recommended NFS mount options for EFS https://docs.aws.amazon.com/efs/latest/ug/mounting-fs-nfs-mount-settings.html

The bullet for the hard option says:

hard – Sets the recovery behavior of the NFS client after an NFS request times out, so that NFS requests are retried indefinitely until the server replies. We recommend that you use the hard mount option (hard) to ensure data integrity. If you use a soft mount, set the timeo parameter to at least 150 deciseconds (15 seconds). Doing so helps minimize the risk of data corruption that is inherent with soft mounts.

Given that recommendation, it sounds like we should be OK using soft instead since we have timeo=600 already. I'll push a commit to use the soft mount option instead.

[jarpat]

Changes look good, not sure why this is showing up again, but the content looks identical to what is in staging now.