-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: (IAC-1266) (IAC-1186) Update kubectl to 1.27 and add support for ingress-nginx v1.9.X #512
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Changes:
This PR updates the kubectl version to
1.27
and also updates the ingress-nginx version to 1.9.5 which supports the K8 versions:1.28, 1.27, 1.26, 1.25
.Note: The logic was updated to support the latest version of ingress by default. For any K8s version out of range for the given ingress version would now need to specify
INGRESS_NGINX_CHART_VERSION
to avoid error.For example: The latest ingress Helm Chart Version is
4.9.0
which supports K8s range1.28, 1.27, 1.26, 1.25
. For K8s version < 1.25.X, user needs to specifyINGRESS_NGINX_CHART_VERSION
. Not specifying theINGRESS_NGINX_CHART_VERSION
will result in following error:Tests:
Verified following scenarios, please details in internal ticket: