Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: (IAC-1266) (IAC-1186) Update kubectl to 1.27 and add support for ingress-nginx v1.9.X #512

Merged
merged 4 commits into from
Jan 12, 2024

Conversation

riragh
Copy link
Member

@riragh riragh commented Jan 8, 2024

Changes:

This PR updates the kubectl version to 1.27 and also updates the ingress-nginx version to 1.9.5 which supports the K8 versions: 1.28, 1.27, 1.26, 1.25.

Note: The logic was updated to support the latest version of ingress by default. For any K8s version out of range for the given ingress version would now need to specify INGRESS_NGINX_CHART_VERSION to avoid error.

For example: The latest ingress Helm Chart Version is 4.9.0 which supports K8s range 1.28, 1.27, 1.26, 1.25. For K8s version < 1.25.X, user needs to specify INGRESS_NGINX_CHART_VERSION. Not specifying the INGRESS_NGINX_CHART_VERSION will result in following error:

fatal: [localhost]: FAILED! => {
    "changed": false,
    "msg": "INGRESS_NGINX_CHART_VERSION isn't set when K8s version is < 1.25."
}

Tests:

Verified following scenarios, please details in internal ticket:

Scenario Provider kubernetes_version kubectl version cadence notes
1 Azure 1.26 1.27.9 stable:2023.12
2 Azure 1.27 1.27.9 fast:2020
3 Azure 1.28 1.27.9 fast:2020 not yet supported by SAS Viya
4 AWS 1.24 1.27.9 lts:2023.03

@riragh riragh added the enhancement New feature or request label Jan 8, 2024
@riragh riragh self-assigned this Jan 8, 2024
Copy link
Member

@thpang thpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please review comment

docs/CONFIG-VARS.md Outdated Show resolved Hide resolved
Copy link
Member

@thpang thpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

docs/CONFIG-VARS.md Outdated Show resolved Hide resolved
Copy link
Member

@thpang thpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riragh riragh merged commit 5650c7f into staging Jan 12, 2024
3 checks passed
@riragh riragh deleted the IAC-1266-1186 branch January 12, 2024 18:03
@riragh riragh mentioned this pull request Jan 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants