Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: (IAC-1188) Update CLUSTER_AUTOSCALER_CHART_VERSION default to 9.34.1 #514

Merged
merged 2 commits into from
Jan 11, 2024
Merged

feat: (IAC-1188) Update CLUSTER_AUTOSCALER_CHART_VERSION default to 9.34.1 #514

merged 2 commits into from
Jan 11, 2024

Conversation

jarpat
Copy link
Contributor

@jarpat jarpat commented Jan 10, 2024 •
edited
Loading

Changes

Updates the default CLUSTER_AUTOSCALER_CHART_VERSION to 9.34.1

Tests

Autoscaler was tested by adding cas workers and seeing if new nodes were spawned and deleted upon uninstallation.

Scenario Provider K8s Version CAS Min/Max Nodes CLUSTER_AUTOSCALER_CHART_VERSION V4_CFG_CAS_WORKER_COUNT Order Cadence Notes
1 AWS v1.26.11-eks-8cb36c9 1 & 5 9.34.1 3 * fast:2020 autoscaler successfully scaled up cas nodes for workers and down upon uninstall
2 AWS v1.28.4-eks-8cb36c9 1 & 5 9.34.1 3 * fast:2020 autoscaler successfully scaled up cas nodes for workers and down upon uninstall

@jarpat jarpat added the enhancement New feature or request label Jan 10, 2024
@jarpat jarpat self-assigned this Jan 10, 2024
thpang
thpang approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@thpang thpang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jarpat jarpat merged commit 0dab9e1 into staging Jan 11, 2024
3 checks passed
@jarpat jarpat deleted the IAC-1188 branch January 11, 2024 17:05
@riragh riragh mentioned this pull request Jan 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thpang thpang thpang approved these changes

@dhoucgitter dhoucgitter dhoucgitter approved these changes

@sayeun sayeun Awaiting requested review from sayeun

@riragh riragh Awaiting requested review from riragh

Assignees

@jarpat jarpat

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jarpat @dhoucgitter @thpang