From a6248aa8020dcbf580270d03869c759d275ec0e2 Mon Sep 17 00:00:00 2001 From: Ritika Patil Date: Tue, 18 Oct 2022 13:06:31 -0400 Subject: [PATCH 1/3] docs: (IAC-697): Updated the min_nodes value for compute node to 1 --- docs/CONFIG-VARS.md | 2 +- variables.tf | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/docs/CONFIG-VARS.md b/docs/CONFIG-VARS.md index ac48ebca..a44b0473 100644 --- a/docs/CONFIG-VARS.md +++ b/docs/CONFIG-VARS.md @@ -220,7 +220,7 @@ The default values for the `node_pools` variable are as follows: compute = { "machine_type" = "Standard_E16s_v3" "os_disk_size" = 200 - "min_nodes" = 0 + "min_nodes" = 1 "max_nodes" = 5 "max_pods" = 110 "node_taints" = ["workload.sas.com/class=compute:NoSchedule"] diff --git a/variables.tf b/variables.tf index 64ec80e3..2638eda9 100644 --- a/variables.tf +++ b/variables.tf @@ -394,7 +394,7 @@ variable "node_pools" { compute = { "machine_type" = "Standard_E16s_v3" "os_disk_size" = 200 - "min_nodes" = 0 + "min_nodes" = 1 "max_nodes" = 5 "max_pods" = 110 "node_taints" = ["workload.sas.com/class=compute:NoSchedule"] From 37356eca7e961b2f3bd977db21295d9af4583cb7 Mon Sep 17 00:00:00 2001 From: Ritika Patil Date: Fri, 21 Oct 2022 15:17:58 -0400 Subject: [PATCH 2/3] docs: (IAC-697): Add note about minimum of 1 node required for compute --- docs/CONFIG-VARS.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/docs/CONFIG-VARS.md b/docs/CONFIG-VARS.md index a44b0473..d3a65e36 100644 --- a/docs/CONFIG-VARS.md +++ b/docs/CONFIG-VARS.md @@ -204,6 +204,8 @@ Additional node pools can be created separate from the default node pool. This i The default values for the `node_pools` variable are as follows: +**Note**: Maintaining a minimum of 1 node in the pool for `compute` node provides the best customer experience at this time as it makes sure that compute-related pods have the required images pulled and ready for use in the environment. + ```yaml { cas = { From f172cc9637b0b78cd0453ff8ff7b23798d4162bc Mon Sep 17 00:00:00 2001 From: Ritika Patil Date: Fri, 21 Oct 2022 16:15:29 -0400 Subject: [PATCH 3/3] docs: (IAC-697): Updated wording basaed on recommendation --- docs/CONFIG-VARS.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/CONFIG-VARS.md b/docs/CONFIG-VARS.md index d3a65e36..579328d3 100644 --- a/docs/CONFIG-VARS.md +++ b/docs/CONFIG-VARS.md @@ -204,7 +204,7 @@ Additional node pools can be created separate from the default node pool. This i The default values for the `node_pools` variable are as follows: -**Note**: Maintaining a minimum of 1 node in the pool for `compute` node provides the best customer experience at this time as it makes sure that compute-related pods have the required images pulled and ready for use in the environment. +**Note**: SAS recommends that you maintain a minimum of 1 node in the pool for `compute` workloads. This allocation ensures that compute-related pods have the required images pulled and ready for use in the environment.. ```yaml {