Support saving images which are identified by SHA rather than tag #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nice if we can pass those sha to the cache action to pick what we want to cache no? |
|
@MostefaKamalLala That sounds like a separate feature - there's an issue for it already, #121, as you've discovered. |
Moetto
added a commit
to Moetto/wach2.0
that referenced
this pull request
Jul 22, 2021
Docker images saved by hash, i.e. kind cluster image, don't work with satackey docker layer caching, causing build to fail. See satackey/action-docker-layer-caching#140 Remove the broken plugin from use.
|
I worked out how to use it the other day - the secret was to enable GitHub Actions on my fork, so it could automatically produce a uses: ZimbiX/action-docker-layer-caching@fix-error-cannot-use-import-statement-outside-a-module-release |
|
@satackey This is confirmed ready to review and merge |
|
@ezequielgarcia We're still waiting for @satackey to review. In the meantime, you can use my fork with the line above =) |
|
@satackey Are you still planning on maintaining this project? 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully resolves #17 and #49.
Images can be pulled by SHA, but these don't get tagged, e.g.:
We can't then use the repo plus non-existent tag to identify it in the call to
docker save. Instead, we can use the image ID, e.g.:I'm fetching these details via:
This project badly needs some tests. In order to test this locally, I had to do so rather hackily.
I haven't tested out restoring yet. Putting this up here to share my progress.