Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tweaking theme provider #49

Merged
merged 3 commits into from
Nov 11, 2024
Merged

fix: tweaking theme provider #49

merged 3 commits into from
Nov 11, 2024

Conversation

kohinoor98
Copy link
Contributor

solves #48

@satnaing
Copy link
Owner

Thanks for pointing out this issue and PR.

I also made a couple of changes

  • disable eslint warning
  • update setThemeState to _setTheme

@kohinoor98
Copy link
Contributor Author

Thanks for such a beautiful template! If there are any additional issues I could work on, plz let me know, would love to contribute

@satnaing satnaing merged commit 9a98533 into satnaing:main Nov 11, 2024
1 check passed
@satnaing
Copy link
Owner

Thanks @kohinoor98
You can try the ESLint upgrading issue #24
However, when I opened that issue, there was no stable React19-compatible ESLint version.
I'm not sure if it's out now or not tho.
You can try that if you want (or if you're interested in doing that)

@kohinoor98
Copy link
Contributor Author

For sure, let me check it over the weekend!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@satnaing satnaing satnaing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kohinoor98 @satnaing