Dependency issue

[amitavmohanty01]

I was able to use savon 2.2.0 with sanitize 2.0.4; but with savon 2.3.0 there is a dependency issue regarding Nokogiri.

[amitavmohanty01]

I guess bd5d098 caused the issue.

Probably it then reduces to a situation where something is a bug for someone and feature for someone else.

[lephyrius]

Im also seeing this:

Bundler could not find compatible versions for gem "nokogiri":
  In Gemfile:
    savon (~> 2.3.0) java depends on
      nokogiri (< 1.6, >= 1.4.0) java

    nokogiri (1.6.0)

[yolk]

Me too. It is getting a little bit annoying because other gems start to depend on nokogiri >=1.6 (for example blather). This causes incompatibility issues with gems depending on savon 2.3.

I do not know of any workaround, even forking savon is not an option in this case.

Wouldn't it be much easier to allow current versions of nokogiri and mentioning the issue for users of ruby 1.8 in the README? At least it would be possible for them to work around the problem.

[rubiii]

thanks for reporting this problem. i will revert this change with the next release.

[joshsmith]

@rubiii What's the status of PR #496 to fix this issue?

[tjarratt]

@joshsmith is this an issue on supported versions of ruby? (eg: 1.9.x, 2.0). The discussion on PR #496 (which spawned PR #511) seems to have come to the conclusion that this only affects ruby 1.8, which is now at EOL.

Full disclaimer : I haven't used savon on ruby 1.8 or 1.9 for a while, and haven't seen this issue crop up at all. A quick perusal of my Gemfile.lock files indicates that nothing else I use has a dependency on nokogiri, which is kind of surprising.

[joshsmith]

@tjarratt I'm on 2.0 and definitely having this issue.

[yolk]

@tjarratt The fix in PR #496 removes the dependency on nokogiri versions smaller than 1.6. So this is currently an issue on every ruby version. The only reason this limitation was added in the first place is the incompatibility of nokogiri => 1.6 with ruby 1.8.7. The PR adds an warning message displayed during installation with rubgems for users of ruby 1.8.7 to avoid nokogiri. This is imho the much much better way of handling the issue than disallowing it for all current of ruby.

PR #496 solves this issue and #511

@rubii Any changes we can get #496 in a new patch version of savon? Anything I could do to make that happen?

[yolk]

Got one thing wrong: rubiii, not rubii:

@rubiii Any changes we can get #496 in a new patch version of savon? Anything I could do to make that happen?

[tjarratt]

@yolk until we bump the version on rubygems.org (which I believe only @rubiii has access to), could you update your Gemfile to use the version on github, and maybe lock it to a specific revision?

At this point I believe we can probably close this issue.

[yolk]

Thanks @tjarratt for merging in the changes. This fixes the issue. But I am still waiting for an gem release, because i am using savon as a dependecy in other gems, so the Gemfile is not an option. Any idear when/how you'll be able to release a new gem version?

[tjarratt]

Alas, I do not have access to the rubygems.org account for Savon. Hoping @rubiii or some other maintainer with those creds will pop into this thread and release a new gem version.

[tanelsuurhans]

Oddly using this in my Gemfile still doesnt fix the issue:
gem "savon", :git => "git://github.com/savonrb/savon.git", :branch => :version2

It still tells me that i need a specific version of nokogiri:
nokogiri (< 1.6, >= 1.4.0) ruby

What gives, what am I missing here?

[msievers]

@tanelsuurhans I think the problem is the "wasabi" dependency, which has the same nokogiri 1.5 lockdown in its gemspec.

[msievers]

@tanelsuurhans There is a pending pull request for wasabi, which fixes this in the same manner as in savon. Have a look at savonrb/wasabi#35 and https://github.com/hooroo/wasabi

[tanelsuurhans]

Yeah I saw it and had to checkout it straight from git. Perhaps we could get both changes properly merged in and released as a minor version bump?

[tjarratt]

Is there any reason why we're maintaining ruby 1.8 compatibility? AFAIK it's been EOL for a while.

ie: why bother with these weird workarounds for 1.8, just remove the check and make a reasonable assertion what version of Nokogiri we require?

[davidsantoso]

@rubiii any update on a new gem version being released on rubygems.org to fix this issue?

[tjarratt]

There should be a release later this week.

Details forthcoming.

Sent From A Very Small Keyboard

On Dec 4, 2013, at 8:35, David Santoso [email protected] wrote:

@rubiii any update on a new gem version being released on rubygems.org to fix this issue?

—
Reply to this email directly or view it on GitHub.

[tjarratt]

Good news everybody!

Savon v2.3.1 and Wasabi 3.2.1 were released last night. These versions don't require Nokogiri <= 1.6, and I explicitly tested that it works with sanitize v 2.0.4

@yolk, @davidsantoso, @amitavmohanty01, @tanelsuurhans, @joshsmith, @lephyrius -- can you try that version out and let me know if it fixes this issue?

[lephyrius]

@tjarratt Works. But im starting to see some other issues.

[tjarratt]

@lephyrius are you seeing more other than issue #520 where tags in requests have Request or Message erroneously applied to them?

[lephyrius]

@tjarratt That error looks really similar to what im getting.

[davidsantoso]

@tjarratt works as well. But I'm getting a `require': cannot load such file -- savon (LoadError) error even though savon is in my gemset. I don't get the issue if I install savon straight from GitHub though. But, I am using savon as a dependency for a gem so it could possibly be on my end?

[tjarratt]

@davidsantoso weird, I was able to create a new project with this Gemfile and require 'savon' from irb. Installing the latest markety uses savon v2.3.1.

Gemfile

source 'https://rubygems.org'
gem 'markety'

tjarratt at awesomeComputer in ~/git/savon-example-w-nokogiri
○ irb
rirb(main):001:0> require 'savon'
=> true
irb(main):002:0> require 'markety'
=> true
irb(main):003:0> 

I'm going to close this issue out and move discussion of bugs in 2.3.1 to the relevant issues. Please re-open this issue or chime back in if this is still unresolved for you.

request tags are no longer correct: #529
Excon and httpi issue with ssl certs: #491

[zarapustra]

try spring stop. It helped me