SAVON 3 Use of Nori should include configurable nori options

[ashrocket]

Though the change log current says that your are not using Nori, you are still using it
in the response. Unfortunately for me one of the cool elements of using the response header, in the request headers (for soap services that return a changing token in the Securtiy header) is not working since you default to snake_case on the symobls returned.

Can we get :

  def self.configure
      yield self
    end


in the savon.rb file  so we can set some options:

mattr_accessor :nori_options
@@nori_options =     nori_options = {
    strip_namespaces: true,
    convert_tags_to: lambda { |tag| tag.snakecase.to_sym }
  }

I'll be happy to fork it, but I'm terrible at writing rspec.

Or if this is undesirable (because you are referencing :envelope, and :body direectly in the response Object)
is there some otherway you recommend getting header elements into camelcase?

For now, I've monkeypatched Nori to camelcase anything inside [:envelope][:header] in my app using :symbol_name.to_s.camelcase.to_sym

[ashrocket]

Ditched the monkey patch in favor of a direct solution:
In the code where I'm storing the security header for re-use I'm doing this:

    def process_header response
      @security_header = camelcase_keys(response.hash[:envelope][:header][:security])
      next_message
    end

where next_message is a function I have to increment my message numebr
and camelcase_keys is defined below to recursively camelcase any symbol keys to match the required input hash
for the service I'm using.

   def camelcase_keys element
      if element.is_a? Hash
        new_element = {}
        element.each do |name,el|
          new_element[name.to_s.camelcase.to_sym] = camelcase_keys(el)
        end
        new_element
      elsif element.is_a? Array
        element.map{|el| camelcase_keys(el)}
      else
        element
      end
    end

[proby]

👍 on this. I don't want all my keys to be symbols. I'd like a way to configure Nori such that it only snake case's the keys, leaving them as strings.

[ashrocket]

change the above code:

element.each do |name,el|
          new_element[name.to_s.camelcase.to_sym] = camelcase_keys(el)
 end

to

element.each do |name,el|
          new_element[name.to_s] = camelcase_keys(el)
end

And you shall have that which you desired

[tjarratt]

@ashrocket I think allowing users to set the Nori options for parsing the response is a reasonable request for Savon3. The method you laid out seems good, but I'd definitely want to get some tests for this behavior before merging anything in.

Seems like a simple test where you pass in a convert_tags_to lambda and the response parsed matches some known good response would be a reasonable first pass at a test for this.

Re: symbols, @proby, there's an outstanding issue in #473 to switch from symbols to strings to avoid a memory leak. Hoping to address that soon.

[ashrocket]

Sure, I think we can add something like ActiveModel::Validator
http://api.rubyonrails.org/classes/ActiveModel/Validator.html

class Person
  include ActiveModel::Validations
  validates_with MyValidator
end

class MyValidator < ActiveModel::Validator
  def validate(record)
    if some_complex_logic
      record.errors[:base] = "This record is invalid"
    end
  end

  private
    def some_complex_logic
      # ...
    end
end

Only savon's api would require a method for convert convert_tags_to