Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasabi dependency requirement is too relaxed for Ruby 3 #996

Closed
sarahsehr opened this issue Dec 15, 2023 · 2 comments
Closed

wasabi dependency requirement is too relaxed for Ruby 3 #996

sarahsehr opened this issue Dec 15, 2023 · 2 comments

Comments

@sarahsehr
Copy link
Contributor

sarahsehr commented Dec 15, 2023

Bug report

Current behavior:

ruby/3.2.1/lib/ruby/gems/3.2.0/gems/wasabi-3.5.0/lib/wasabi/parser.rb:89:in `parse_url': undefined method `unescape' for URI:Module (NoMethodError)

      unescaped_url = URI.unescape(url.to_s)
                         ^^^^^^^^^

Steps to reproduce current behavior:

  1. depend on savon
  2. depend on version of wasabi v3.5.0
  3. Run app console
  4. Call Savon.client.call, for example:
Savon.client(wsdl: 'http://www.dneonline.com/calculator.asmx?WSDL').call(:add)

Expected behavior:

Savon requires that the minimum wasabi version is v3.7.

The cause of this Ruby 3 related error is removed in v3.6. However, wasabi was not tested against any version of Ruby 3 until v3.70.

System information:

  • ruby version: 3.2.1
  • savon version: tested against 2.11.2 and 2.13.0. Note savon v2.14.0 is okay because savon's httpi version requirement is incompatible with wasabi v3.5's httpi version requirement.

Additional Context

I'm filing this bug because it took me time to debug this when upgrading to Ruby 3. Hoping to save someone else the trouble.

@olleolleolle
Copy link
Contributor

Would you want to make a PR updating that requirement (which now says 3.4 or higher) to something which avoids defects?
https://github.com/savonrb/savon/blob/master/savon.gemspec#L21C3-L21C40

@olleolleolle
Copy link
Contributor

Closed by #997.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants