Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backlog of changes #3611

Open
wants to merge 19 commits into
base: master
Choose a base branch
from

Conversation

giantcavespider
Copy link
Contributor

remove rare world breaking object from precursor underground
hopefully fix that annoying bug with flyers swimming
fix mistake with monster/npc fall damage
remove forced gravity from lush dungeons (will now use world gravity)
nerf cattle feed harder
make nailery edible to robots
don't have objects be both crushable and siftable
re-add direstone crushing
some minor fixes

@sayterdarkwynd
Copy link
Owner

sayterdarkwynd commented Nov 23, 2024

don't have objects be both crushable and siftable

  • absolutely not. This is intentional , and desired, to provide agency on what output a player might desire. I won't approve this change for the master branch.

Seeing lots of simple changes here, beyond that. What exactly is going on in the mmUpgrade change?

@giantcavespider
Copy link
Contributor Author

the change with crushing/sifting was made before and I assumed it was accidentally reverted by a contributor. (the original reason for doing so was the precursor forge).
the mmupgrade change was just me realizing a previous decision was probably a bad idea.

@edwardspec
Copy link
Contributor

edwardspec commented Nov 24, 2024

I assumed it was accidentally reverted by a contributor.

Yes, your change is correct.

These 3 crushings have already been removed in #3404. @Argenttip accidentally readded them in eb3f8ca.

There were other errors in eb3f8ca: it added blackslimematerial (solid) to centrifuge and removed crushing of direstone (rock).

@Argenttip
Copy link
Contributor

Argenttip commented Nov 25, 2024

2024_11_24_23_55_22_feedback_frackinuniverse_Discord

Black slime was added as per this list. I don't agree with some of the items and their processing stations, but I'm not sure how much leeway they're giving.

@sayterdarkwynd
Copy link
Owner

You don't need to agree: that's where they go.

@sayterdarkwynd
Copy link
Owner

sayterdarkwynd commented Dec 4, 2024

"remove forced gravity from lush dungeons (will now use world gravity)"

For this change, have you tested the effect it has on the Dark Davern rope/jump areas? we can't provide a change to gravity if it nullifies the need for rope or the jump tech. That's the reason it had a set gravity: parity for all species.

@giantcavespider
Copy link
Contributor Author

that's not for the dark cavern, it's for vina's lab and the overgrown house.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants