Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize visual regression check when facing a job re-run #2728

Open
jeripeierSBB opened this issue Jun 10, 2024 · 0 comments
Open

Stabilize visual regression check when facing a job re-run #2728

jeripeierSBB opened this issue Jun 10, 2024 · 0 comments

Comments

@jeripeierSBB
Copy link
Contributor

Currently, there is no visible visual regression status check whenever there were more than on run attempts. With that, important changes could be invisible at the checks.
We need to change secure workflow like following:

  visual-regression:
    runs-on: ubuntu-latest
    if: >
      (github.event.workflow_run.event == 'pull_request' || (github.event.workflow_run.event == 'push' && github.event.workflow_run.run_attempt > 1)) &&
      github.event.workflow_run.conclusion == 'success'
     
...
      
      - name: get workflow id
        uses: actions/github-script@v7
        with:
          script: |
            # If pull request => context.event.workflow_run.id
            # If push => find check suite with head sha and get newest PR (we need PR Number and workflow id)
            # Following steps will need those vars

 ...

@jeripeierSBB jeripeierSBB converted this from a draft issue Jun 10, 2024
@jeripeierSBB jeripeierSBB changed the title Stabilize visual regression check when more than one run attempt Stabilize visual regression check with re-runs Jun 10, 2024
@jeripeierSBB jeripeierSBB changed the title Stabilize visual regression check with re-runs Stabilize visual regression check when facing a job re-run Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant