-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove any type for Angular wrapper #3297
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Should we consider it a breaking change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
We have done stricter types in the past without marking it as a breaking change, if the expectations mostly aligns. I feel that is the case here as well, so we can skip marking it as a breaking change.
...visual-regression-app/src/components/test-case/image-diff/fullscreen-diff/fullscreen-diff.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Lukas Spirig <[email protected]>
No description provided.