Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove any type for Angular wrapper #3297

Merged
merged 2 commits into from
Dec 13, 2024

Conversation

DavideMininni-Fincons
Copy link
Contributor

No description provided.

Copy link
Contributor

@TomMenga TomMenga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Should we consider it a breaking change?

@github-actions github-actions bot added pr: peer review approved Pull request has been approved by a peer review and removed pr: peer review required A peer review is required for this pull request labels Dec 13, 2024
Copy link
Contributor

@kyubisation kyubisation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
We have done stricter types in the past without marking it as a breaking change, if the expectations mostly aligns. I feel that is the case here as well, so we can skip marking it as a breaking change.

@github-actions github-actions bot added the pr: lead review approved Pull request has been approved by a lead review label Dec 13, 2024
@github-actions github-actions bot temporarily deployed to pr3297 December 13, 2024 15:53 Inactive
@github-actions github-actions bot temporarily deployed to pr3297-diff December 13, 2024 15:54 Inactive
Co-authored-by: Lukas Spirig <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
diff-available pr: lead review approved Pull request has been approved by a lead review pr: peer review approved Pull request has been approved by a peer review pr: visual review required preview-available target: 2.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants