Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verification in the spei source codes #79

Open
wkqian06 opened this issue Dec 3, 2024 · 0 comments
Open

Verification in the spei source codes #79

wkqian06 opened this issue Dec 3, 2024 · 0 comments

Comments

@wkqian06
Copy link

wkqian06 commented Dec 3, 2024

Hi there, thank you for creating this wonderful package!

I found something strange when I went into the spei source codes from Lines 282-286

      if (distribution == "Gamma" | distribution == "PearsonIII") {
        spei[ff, s] <- qnorm(pze + (1 - pze) * pnorm(spei[ff, 
          s]))
      }
      spei[ff, s] <- qnorm(cdf_res)

The Lines 282-285 seem useless because the spei[ff, s] are set to NA according to the precious setting in Line 222 spei <- acu * NA.

So, do you think it should be ignored? which makes sense because cdf_res is the essential one for the final spei.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant