Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

space between function () and {} #235

Open
1 task
jsupratman13 opened this issue Dec 26, 2024 · 2 comments
Open
1 task

space between function () and {} #235

jsupratman13 opened this issue Dec 26, 2024 · 2 comments
Labels
question Further information is requested ros2 For ros2

Comments

@jsupratman13
Copy link
Contributor

jsupratman13 commented Dec 26, 2024

概要

前に聞いたかもしれないが、

https://github.com/sbgisen/sbgisen_gz_sim/actions/runs/12502368312/job/34881210167?pr=16

- virtual void start() {}; 
+ virtual void start(){};

にしろとCIが言ってるけど、そもそも space 外すのが正しかったけ

目的
提案内容
タスク

  • 細かいタスクに分解できているなら書き出す
@jsupratman13 jsupratman13 added question Further information is requested ros2 For ros2 labels Dec 26, 2024
@Tacha-S
Copy link
Contributor

Tacha-S commented Dec 26, 2024

{}の中身が空の場合はそうなるはずです
precommitでもそうなるはずですけどなりませんか?

@jsupratman13
Copy link
Contributor Author

自分の環境だとprecommitがそうではないと文句言ってくる。
ちょっと調べておく

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested ros2 For ros2
Projects
None yet
Development

No branches or pull requests

2 participants