Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Runtime of some tests could be reduced by reducing num simulations #575

Closed
janfb opened this issue Jan 5, 2022 · 2 comments
Closed

Runtime of some tests could be reduced by reducing num simulations #575

janfb opened this issue Jan 5, 2022 · 2 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hackathon

Comments

@janfb
Copy link
Contributor

janfb commented Jan 5, 2022

See #413

@jnsbck
Copy link
Contributor

jnsbck commented Jan 25, 2022

So I ran pytest --durations=0 to determine which tests to prioritise and this was the output:
pytest_output.txt

The main two takeaways:

  1. linearGaussian_snle_test.py takes by far the longest (see top 10).
319.54s call     tests/linearGaussian_snle_test.py::test_c2st_multi_round_snl_on_linearGaussian[3]
164.86s call     tests/linearGaussian_snle_test.py::test_c2st_multi_round_snl_on_linearGaussian[1]
156.51s call     tests/linearGaussian_snpe_test.py::test_sample_conditional
136.53s call     tests/inference_with_NaN_simulator_test.py::test_inference_with_nan_simulator[SNLE_A-True-0.05]
120.97s call     tests/abc_test.py::test_smcabc_sass_lra[2-True]
116.58s call     tests/abc_test.py::test_smcabc_kde[cv]
112.93s call     tests/inference_on_device_test.py::test_training_and_mcmc_on_device[cuda:0-cuda:00-cpu-SNLE_A-nsf-slice_np]
112.54s call     tests/abc_test.py::test_smcabc_inference_on_linear_gaussian[gaussian-2]
111.00s call     tests/inference_on_device_test.py::test_training_and_mcmc_on_device[cuda:0-cuda:00-cuda:0-SNLE_A-nsf-slice_np]
110.83s call     tests/abc_test.py::test_smcabc_inference_on_linear_gaussian[uniform-2]
106.27s call     tests/abc_test.py::test_smcabc_inference_on_linear_gaussian[gaussian-1]
  1. test_c2st_sre_variants_on_linearGaussian in linearGaussian_snre_test.py failed on my machine.

@janfb
Copy link
Contributor Author

janfb commented Jan 30, 2024

fixed through #923 and #924

@janfb janfb closed this as completed Jan 30, 2024
@janfb janfb self-assigned this Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hackathon
Projects
None yet
Development

No branches or pull requests

2 participants