tutorial on SBC reproducibility #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaeldeistler
force-pushed
the
calib
branch
from
ad5af80
to
a641f6d
Compare
michaeldeistler
force-pushed
the
calib
branch
from
a641f6d
to
01248fb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SBC results in the tutorial were not reproducible.
To fix this:
Also, I changed the way that the predictive are plotted. Previously, the limits were [0.75 * x_o, 1.25 * x_o] but, because it was not reproducible, it could happen that x_o is very small and thus the limits are very close to each other. It is now [x_o - 1, x_o + 1].
Sorry for the huge diff, I tried in Jupyter lab and vs code but neither changed the indentation (which cases the diff)