-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor CI tests for speed #923
Conversation
Thanks! Running the tests now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On my MBP with M3 the timings are 422.69s
vs 170.27s
. Awesome!
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #923 +/- ##
==========================================
- Coverage 75.46% 75.28% -0.18%
==========================================
Files 80 80
Lines 6284 6284
==========================================
- Hits 4742 4731 -11
- Misses 1542 1553 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The "fast" tests we run for CI became quite slow:
pytest -m "not slow and not gpu"
To speed them up I removed a couple of duplicate tests and used better MCMC parameters.
The biggest speed up comes from using
slice_np_vectorized
with many chains and few warm up steps (when posterior accuracy is not tested).The speed up is about 30%.
@michaeldeistler can you confirm by testing on
main
and on this branch locally?I separated commits per test file to be able to correct potential misses. We can squash the commits when merging.
TODO: