-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MRU isn't selected immedately on tab close. #89
Comments
The API that that extension uses is cool stuff, but it's not cross browser and I am trying to keep things compatible as much as possible. |
Then I'd like to add an option to turn MRU-on-close off. While it is in your description, I don't think this is like how windows stack or any of my IDE's tabs work. What do you think? |
That is the whole point of TabDeque, if you turn it off, what's left? You basically fall back to the browser default behaviour?And that definitely does not behave like a normal window stack. If I have 5 tabs, A B C D E and I select A C E B D and then close them currently selected one after the other the order I expect is D B E C A. That's how my window manager works and what TabDeque implements but not at all how Chrome works. Because of this difference there can be issues. |
Ahah, for me the main reason to install this add-on was to have the hotkeys to cycle through the deque. At work I do a lot of configuration in webapp interfaces. It's always the same back and forth, but on different groups of tabs all the time. That's also how my IDE back/forward hotkeys work, which I use when I'm exploring code. I don't expect MRU behavior when I'm closing tabs, cause then I'm just cleaning up. Even with the issue, MRU-on-close is a bit too jumpy for my taste. This is just my way of thinking, not saying it is the right way :) |
Then you can just use the normal shortcuts for switching between tabs, |
I guess want best of both worlds :) Sometimes I want MRU, sometimes I want tab bar order.
But maybe this would make that unnecessary, I'll give it a try! Either ways, I'm just making suggestions here. It's your addon in the end, you decide. I'll still make a pull request for the thing from the other thread. |
@VulumeCode I am running a personal fork of this in which I have used I haven't published it in a repo, but here is the gist of it |
New Issue Checklist (tick off like this:
[x]
)What is your browser?
What is your operating system?
Description (please include examples/screenshots where applicable)
When closing a tab, the MRU tab is selected only after Firefox switches to the tab it would normally select. This could trigger some things on that page (and it messes with my new extension). It is possible to switch immediately, as this plugin does https://addons.mozilla.org/en-US/firefox/addon/mru-tab-succession/?utm_source=addons.mozilla.org&utm_medium=referral&utm_content=search
The text was updated successfully, but these errors were encountered: