Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2.x] Add tests for #1430 (content hash) #1441

Open
Friendseeker opened this issue Oct 7, 2024 · 1 comment
Open

[2.x] Add tests for #1430 (content hash) #1441

Friendseeker opened this issue Oct 7, 2024 · 1 comment
Assignees
Milestone

Comments

@Friendseeker
Copy link
Member

Friendseeker commented Oct 7, 2024

While #1430 passed regression testing, we still need to add more testing to verify it produces correct, machine-independent hash.

We can probably pin a scala version, store a known correct hash for a source file in a variable and test that the source file hash does not change throughout incremental compilation. Need to test for both macro & non macro files.

Some scripted test involving adding a comment to a macro (or upstream of a macro) and asserting no downstream compilation would also be good test to add.

@Friendseeker Friendseeker self-assigned this Oct 7, 2024
@Friendseeker Friendseeker added this to the 2.0.0 milestone Oct 7, 2024
@Friendseeker
Copy link
Member Author

Thinking again I feel #1430 may have weird interaction with pipelining. The scripted test about pipelining passed, but there's still the issue that we are only hashing early product instead of final product.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant