You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While #1430 passed regression testing, we still need to add more testing to verify it produces correct, machine-independent hash.
We can probably pin a scala version, store a known correct hash for a source file in a variable and test that the source file hash does not change throughout incremental compilation. Need to test for both macro & non macro files.
Some scripted test involving adding a comment to a macro (or upstream of a macro) and asserting no downstream compilation would also be good test to add.
The text was updated successfully, but these errors were encountered:
Thinking again I feel #1430 may have weird interaction with pipelining. The scripted test about pipelining passed, but there's still the issue that we are only hashing early product instead of final product.
While #1430 passed regression testing, we still need to add more testing to verify it produces correct, machine-independent hash.
We can probably pin a scala version, store a known correct hash for a source file in a variable and test that the source file hash does not change throughout incremental compilation. Need to test for both macro & non macro files.
Some scripted test involving adding a comment to a macro (or upstream of a macro) and asserting no downstream compilation would also be good test to add.
The text was updated successfully, but these errors were encountered: