Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Make Consistent Analysis Compression toggleable #1509

Open
Friendseeker opened this issue Dec 3, 2024 · 1 comment
Open

Comments

@Friendseeker
Copy link
Member

Friendseeker commented Dec 3, 2024

problem

Consistent Analysis compression is currently not toggle-able and on by default. This

  • has performance implication on potato computers
  • causes confusion when people use ConsistentAnalysisFormat.text and sees garbled output in text editor (as they assume text format output is directly openable by text editor, while they actually need to unzip it first).

expectation

  • Offer a way to disable the compression
  • Consider making the compression off by default (or at least off by default for ConsistentAnalysisFormat.text.

notes

Here was an instance of downstream zinc user asking why ConsistentAnalysisFormat.text yields garbled output

I'm having issues using the new ConsistentAnalysisStore in Mill. I tried to use ConsistentAnalysisStore.text in https://github.com/com-lihaoyi/mill/pull/4065/files#diff-d7eb4aebc8fc9a837dc90a5215cee479037fef11cc4071bf4a6242fc6baf2014R486, but the generated zinc.txt file still seems to be binary. Would you be able to take a look and see if I'm missing anything obvious?

(https://discord.com/channels/632150470000902164/635669047588945930/1313414992267182133)

@Friendseeker Friendseeker changed the title Feature Request: Make Consistent Analysis Compression toggleable Feature Request: Make Consistent Analysis Compression toggleable Dec 3, 2024
@SethTisue
Copy link
Member

TIL "potato computer"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants