-
Notifications
You must be signed in to change notification settings - Fork 503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retract previously opened Pull Request #3488
Conversation
The `updates.retraced` section of the `scala-steward.conf` allows to declare updates that should be retracted. Each entry must have a `reason, a `doc` URL and a list of dependency patterns. Example: ``` updates.retracted = [ { reason = "Ignore version 3.6.0 as it is abandoned due to broken compatibility", doc = "https://contributors.scala-lang.org/t/broken-scala-3-6-0-release/6792", artifacts = [ { groupId = "org.scala-lang", artifactId = "scala3-compiler", version = { exact = "3.6.0" } } ] } ] ``` Retraction of Pull Request is only possible, if the workspace is persisted correctly. (https://github.com/scala-steward-org/scala-steward/blob/main/docs/faq.md#why-doesnt-self-hosted-scala-steward-close-obsolete-prs) Fixes: #3445
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3488 +/- ##
==========================================
- Coverage 90.07% 89.67% -0.41%
==========================================
Files 170 171 +1
Lines 3497 3526 +29
Branches 320 357 +37
==========================================
+ Hits 3150 3162 +12
- Misses 347 364 +17 ☔ View full report in Codecov by Sentry. |
outstanding, thank you for this!! I'm eager to help publicize it once it's deployed (it's not deployed yet is it?) |
oh, a thought just occurred to me... and I hate to suggest it so late... suppose a Steward PR gets merged, but the version in question is retracted afterwards. Will the steward leave a comment on the merged PR to notify the maintainers? |
I haven't rolled this into a released, yet. Sadly I only went for the simpler option. All PRs that are still open will get closed with a comment. Otherwise I would have to keep book which closed PR did already got a retraction comment. |
The 1st was closed, the 2nd got a comment even though is was already closed. Maybe the local state of Steward wasn't updated. For this use case even better. |
The
updates.retraced
section of thescala-steward.conf
allows to declare updates that should be retracted. Each entry must have areason
, adoc
URL and a list of dependency patterns.Example:
Retraction of Pull Request is only possible, if the workspace is persisted correctly. (https://github.com/scala-steward-org/scala-steward/blob/main/docs/faq.md#why-doesnt-self-hosted-scala-steward-close-obsolete-prs)
Fixes: #3445