Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancel stale CI executions when CI is re-triggered in the same branch/PR #21974

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

WojciechMazur
Copy link
Contributor

@WojciechMazur WojciechMazur commented Nov 19, 2024

Cancels any in-progress runs within the same group identified by workflow name and GH reference (branch or tag)
For example it would:

  • terminate previous PR CI execution after pushing more changes to the same PR branch
  • terminate previous on-push CI run after merging new PR to the main

Motivated by a long CI queue (taking even up to 10h ) and limited amount of self-hosted runners. Currently merging PR to main triggers a new on-push CI run (taking ~1.5h) - merging multiple PR in a row schedules a separate CI run (that is probably never going to be investigated if it fails)

The second empty commit shows how cancelation is done. Previously triggered CI run is cancelled, any enqueued or currently executed jobs are stopped and annotated with message Canceling since a higher priority waiting request for 'Dotty-refs/pull/21974/merge' exists

Copy link
Member

@hamzaremmal hamzaremmal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've wanted to do this change a long time ago but it seemed that everyone have a different opinion about it. Maybe a question for tomorrow's core meeting.

@Gedochao Gedochao added the stat:needs decision Some aspects of this issue need a decision from the maintainance team. label Nov 19, 2024
@hamzaremmal hamzaremmal removed the stat:needs decision Some aspects of this issue need a decision from the maintainance team. label Nov 20, 2024
@WojciechMazur WojciechMazur merged commit 2be2a60 into scala:main Nov 21, 2024
29 checks passed
@WojciechMazur WojciechMazur deleted the ci/cancel-stale-ci branch November 21, 2024 12:08
KacperFKorban pushed a commit to dotty-staging/dotty that referenced this pull request Nov 29, 2024
…/PR (scala#21974)

Cancels any in-progress runs within the same group identified by
workflow name and GH reference (branch or tag)
For example it would:
- terminate previous PR CI execution after pushing more changes to the
same PR branch

Co-authored-by: Tomasz Godzik <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants