[CI] trigger library tests on cc changes #22055
Conversation
Changes to the capture checker should automatically trigger the scala2 library test.
| && ( contains(github.event.pull_request.changed_files, 'scala2-library-cc/') | ||
| || contains(github.event.pull_request.changed_files, 'scala2-library-cc-tasty/') | ||
| || contains(github.event.pull_request.changed_files, 'compiler/src/dotty/tools/dotc/cc/') | ||
| ) |
There was a problem hiding this comment.
We should also include capture test folders.
There was a problem hiding this comment.
I was thinking about this, but why would that be necessary? I don't see how changing the capture tests could affect the outcome of the standard library tests.
There was a problem hiding this comment.
To make sure the modified/added test has the same behaviour/output with the two versions of stdlib.
There was a problem hiding this comment.
PS: Speaking of capture tests: they are spread out throughout the tests folder, according to grep -nHr captureChecking ./tests. Should we put them under a central folder? @odersky
There was a problem hiding this comment.
PPS: Those specific lines in the yaml file do not appear to work as intended. ChatGPT lied to me 😢
Superseeds #22055 When working on capture checking, error messages might change if we compile using the cc library or the non-cc library. Usually, this errors are not catched when running the workflows on each PR and are only detected on nightly builds. The following PR introduces a new workflow that is trigger on each merge to main and on each change to cc related files.
Changes to the capture checker should automatically trigger the scala2 library test.
I'm using this draft PR to test the triggers.