-
-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Unused field policies, Merging transformations, Recursive Patchers #614
Draft
MateuszKubuszok
wants to merge
34
commits into
master
Choose a base branch
from
merging-transformations
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MateuszKubuszok
force-pushed
the
master
branch
from
December 6, 2024 14:06
1ebf9a0
to
eb2ddcb
Compare
MateuszKubuszok
force-pushed
the
merging-transformations
branch
from
January 5, 2025 19:05
a08ca86
to
d2f1c6d
Compare
MateuszKubuszok
force-pushed
the
merging-transformations
branch
from
January 7, 2025 13:03
d2f1c6d
to
0d8b516
Compare
This was
linked to
issues
Jan 8, 2025
MateuszKubuszok
changed the title
WIP: Merging transformations
WIP: Unused field policies, Merging transformations
Jan 13, 2025
MateuszKubuszok
changed the title
WIP: Unused field policies, Merging transformations
WIP: Unused field policies, Merging transformations, Recursive Patchers
Jan 14, 2025
This was
linked to
issues
Jan 14, 2025
5 tasks
MateuszKubuszok
added this to the Merge transformations and Patcher rewrite (1.7.0) milestone
Jan 15, 2025
MateuszKubuszok
force-pushed
the
merging-transformations
branch
from
January 15, 2025 17:32
3b2e151
to
fb092d6
Compare
5 tasks
…match before comparator result)
…use in Option/Collection fallback merging code
MateuszKubuszok
force-pushed
the
merging-transformations
branch
from
January 16, 2025 11:18
fb092d6
to
643a60b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will implement the long awaited:
Patcher
in nested fields - Support nested patchers that look for implicits #133No ETA at the moment.
Plan
kick-off policieskick off fallbacksimplement product to product mergeimpliment Optional values mergereimplement Patchers special case as special case of merging transformtionProgress
unused field policy/unmatched subtype policy - Policy for checking which fields were used for transformation #248
withFieldUnused
to suppress errors per field with policy enabledwithSubtypeUnmatched
to suppress errors per subtype with policy enabledmerging transformations - Support for mapping multiple case classes #115
Fallback
toTransformerOverrides
withFallback
DSL methodwithFallbackFrom
DSL methodval fallbacks: List[(Path, ExistentialExpr)]
toTransformationContext
TransformerOverrides.Fallback
type inTransformerConfiguration
src: Expr[From]
in recursionProductToProduct
OptionToOption
/ToOption
/UnwrapOption
orElse
chainIterableToIterable
/MapToMap
EitherToEither
Either
orElse
(with 2.12 workaround)orElse
chainSealedToSealed
AnyVal
rulesrecursive Patchers - Rewrite Patchers as a special case of multiple case classes mapping #538, Nested patchers don't work with subset of fields #119, Support nested patchers that look for implicits #133
withFieldConst
+withFieldComputed
withFieldUnused
withPatchedFlag
other docs
@since TODO