Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Common Runnables in Run Gutter #37

Closed
Luka-J9 opened this issue Dec 30, 2024 · 4 comments · Fixed by #38
Closed

Support Common Runnables in Run Gutter #37

Luka-J9 opened this issue Dec 30, 2024 · 4 comments · Fixed by #38

Comments

@Luka-J9
Copy link
Contributor

Luka-J9 commented Dec 30, 2024

FP Frameworks in Scala have their own runnables that are not "App"

examples:
ZIOAppDefault
IOApp.Simple
KyoApp

Similar to #36 this can get unwieldy if it's a long list of custom types

Whatever strategy used to employ there, should likely be used here as well

@tgodzik
Copy link
Contributor

tgodzik commented Dec 30, 2024

The best option is to probably query information from Metals, but I am not sure if that's possible. It seems totally seperate from LSP

@Luka-J9
Copy link
Contributor Author

Luka-J9 commented Dec 30, 2024

Yeah as far as I can tell the information is sourced from Tree sitter. Looking at other projects they seem to do what you've already done.

I can try to dig through issues and/or ask the Zed project if there is a mechanism for getting this in another way.

Assuming the scm files are the only way of doing this, and given the relative popularity of zio/cats, maybe it's worth adding anyway?

If not, it might be worth adding a blurb in the readme about this. It wasn't clear to me if I had done something wrong in the runnables script for a little while before digging into this.

Let me know any which way, happy to contribute!

@tgodzik
Copy link
Contributor

tgodzik commented Dec 30, 2024

Assuming the scm files are the only way of doing this, and given the relative popularity of zio/cats, maybe it's worth adding anyway?

I don't love Zed's approach in this case. but if there is no other way around it then go ahead!

@Luka-J9
Copy link
Contributor Author

Luka-J9 commented Jan 1, 2025

I think I found a related issue already in Zed.

zed-industries/zed#16160

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants