Incorrect highlighting and renames with multi val statement

[tgodzik]

Describe the bug

  def runtimeResources: List[AbsolutePath] = platform match {
    case jvm: Platform.Jvm =>
      // single files cannot be added on the classpath
      val (sin@@gleFiles, correctEntries) =
        jvm.resources.partition(path => path.isFile && !path.syntax.endsWith(".jar"))
      val tempResources = Files.createTempDirectory("runtime")
      for (file <- singleFiles) {
        Files.copy(file.underlying, tempResources, StandardCopyOption.REPLACE_EXISTING)
      }
      AbsolutePath(tempResources) :: correctEntries
    case _ => resources
  }

Expected behavior

Only one of singleFiles or correctEntries should be highlighted.

Should reproduce with some more simple cases

This is in the Bloop repository with Scala 2.12.20

Operating system

Linux

Editor/Extension

VS Code

Version of Metals

v1.4.2

Extra context or search terms

highlighting rename multi val

[kasiaMarek]

Smaller reproduction of the issue:

object O {
    def runtimeResources = {
        val (singleFiles, correctEntries) = (???, ???)
    }
}

[kasiaMarek]

This is caused by incorrect positions in the rhs of a synthetic definition. Upstream issue: scala/bug#13078. Alternatively, as a workaround, we can avoid traversing children of synthetic definition (I'm not sure that this will never break go to references but I did not find an example where it would).