New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Supports for React v18+ with Typescript #27

Open

CamboimGabriel opened this issue Mar 31, 2023 · 2 comments

CamboimGabriel commented Mar 31, 2023

If we try to use it causes an error

unitedustom commented May 4, 2023

Yeah i'm getting the same problem when trying to use it with Typescript.

davepenfold commented Mar 3, 2024

Hello,
I can offer some suggestions, I have two questions about the type definitions for this project:

react-cloudimage-responsive/index.d.ts

Line 33 in 26be77a

doNotReplaceURL: boolean;

Shouldn't doNotReplaceURL be an optional property like all the others? If this property is omitted it causes a TS error.
react-cloudimage-responsive/index.d.ts

Line 22 in 26be77a

class CloudimageProvider extends React.Component<{ config: CloudimageProviderConfig }> { }

children property is not defined here, I believe it should be? This is what is likely causing the TS error provided in this issue. It could be of type React.ReactNode ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment