Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request Context missing auth info #154

Closed
LaurenSpiegel opened this issue Sep 7, 2016 · 6 comments
Closed

Request Context missing auth info #154

LaurenSpiegel opened this issue Sep 7, 2016 · 6 comments
Assignees

Comments

@LaurenSpiegel
Copy link
Contributor

It appears that the requestContext being received by Vault does not contain the authType and signature version even though being set here -- https://github.com/scality/Arsenal/blob/master/lib/auth/auth.js#L67

Needs further investigation.

@LaurenSpiegel LaurenSpiegel self-assigned this Sep 7, 2016
@ghost
Copy link

ghost commented Sep 7, 2016

For the investigation, can you try it with the Auth API Refactor branches ? maybe it fixes things, or maybe it would be the opportunity to fix it ?

@alexandre-merle
Copy link
Contributor

alexandre-merle commented Sep 7, 2016

@DavidPineauScality yes probably solved in your pull request, because this line is wrong actually, res contain a field data, and that field contains signatureVersion and authType, so here we set values to undefined :)

@LaurenSpiegel
Copy link
Contributor Author

LaurenSpiegel commented Sep 7, 2016

I agree with Alex. This fixes it -- https://github.com/scality/Arsenal/pull/119/files#diff-4046a881f95c5cd889f1b21f47ac0d40R114

Plus you return all of the info (including signature age) in the data object. What is the status on merging this?

Along with it we can merge a test in integration which uses a test with a sig version condition.
@nicolas2bert

@ghost
Copy link

ghost commented Sep 7, 2016

As far as I remember, it's pretty close to be Okay (at least for this first
step), but the ongoing GA effort is stalling that for now. Hopefully
mergeable next week ? I'll need your and alexandre's reviews, obviously.

On Wed, Sep 7, 2016 at 7:32 PM, Lauren Spiegel [email protected]
wrote:

I agree with Alex. This fixes it -- https://github.com/scality/
Arsenal/pull/119/files#diff-4046a881f95c5cd889f1b21f47ac0d40R114

Plus you return all of the info (including signature age) in the data
object. What is the status on merging this?

Along with it we can merge a test in integration which uses a test with a
sig version condition.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#154 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ANpZZ1_iwVoBzNvu6wigFchN5aVdT5TKks5qnvUZgaJpZM4J2eur
.

David Pineau
Scality R&D Engineer

http://bit.ly/2bHLMkp

@ghost
Copy link

ghost commented Sep 7, 2016

@LaurenSpiegel Oh my bad... There's one issue...
UTAPI is now using Arsenal's API, so this needs a branch/PR Too....

@alexandre-merle
Copy link
Contributor

Fixed by #119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants