-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Request Context missing auth info #154
Comments
For the investigation, can you try it with the Auth API Refactor branches ? maybe it fixes things, or maybe it would be the opportunity to fix it ? |
@DavidPineauScality yes probably solved in your pull request, because this line is wrong actually, res contain a field data, and that field contains signatureVersion and authType, so here we set values to undefined :) |
I agree with Alex. This fixes it -- https://github.com/scality/Arsenal/pull/119/files#diff-4046a881f95c5cd889f1b21f47ac0d40R114 Plus you return all of the info (including signature age) in the data object. What is the status on merging this? Along with it we can merge a test in integration which uses a test with a sig version condition. |
As far as I remember, it's pretty close to be Okay (at least for this first On Wed, Sep 7, 2016 at 7:32 PM, Lauren Spiegel [email protected]
David Pineau |
@LaurenSpiegel Oh my bad... There's one issue... |
Fixed by #119 |
It appears that the requestContext being received by Vault does not contain the authType and signature version even though being set here -- https://github.com/scality/Arsenal/blob/master/lib/auth/auth.js#L67
Needs further investigation.
The text was updated successfully, but these errors were encountered: