From 32be7c3f92f80321d1b4ac4d0f0319f0a1906c18 Mon Sep 17 00:00:00 2001 From: Anurag Mittal Date: Fri, 6 Dec 2024 13:06:24 +0100 Subject: [PATCH] COSI-39: add-default-case-for-service --- pkg/driver/provisioner_server_impl.go | 3 +++ pkg/driver/provisioner_server_impl_test.go | 13 +++++++++++++ 2 files changed, 16 insertions(+) diff --git a/pkg/driver/provisioner_server_impl.go b/pkg/driver/provisioner_server_impl.go index 31800d67..63d37110 100644 --- a/pkg/driver/provisioner_server_impl.go +++ b/pkg/driver/provisioner_server_impl.go @@ -177,6 +177,9 @@ func initializeObjectStorageClient(ctx context.Context, clientset kubernetes.Int return nil, nil, status.Error(codes.Internal, "failed to initialize IAM client") } klog.V(3).InfoS("Successfully initialized IAM client", "endpoint", storageClientParameters.Endpoint) + default: + klog.ErrorS(nil, "Unsupported object storage provider service", "service", service) + return nil, nil, status.Error(codes.Internal, "unsupported object storage provider service") } return client, storageClientParameters, nil } diff --git a/pkg/driver/provisioner_server_impl_test.go b/pkg/driver/provisioner_server_impl_test.go index 801cbcd5..a551a91c 100644 --- a/pkg/driver/provisioner_server_impl_test.go +++ b/pkg/driver/provisioner_server_impl_test.go @@ -339,6 +339,19 @@ var _ = Describe("initializeObjectStorageClient", Ordered, func() { Expect(s3Params.Region).To(Equal("us-west-2")) }) + It("should return InvalidArgument error for unsupported object storage provider service", func() { + _, err := clientset.CoreV1().Secrets("test-namespace").Create(ctx, secret, metav1.CreateOptions{}) + Expect(err).To(BeNil()) + + client, params, err := driver.InitializeClient(ctx, clientset, parameters, "UnsupportedService") + + Expect(client).To(BeNil()) + Expect(params).To(BeNil()) + Expect(err).To(HaveOccurred()) + Expect(status.Code(err)).To(Equal(codes.Internal)) + Expect(err.Error()).To(ContainSubstring("unsupported object storage provider service")) + }) + It("should return error when FetchSecretInformation fails", func() { delete(parameters, "objectStorageSecretName")